[Security_Solution][Resolver] Style adjustments per UX #71179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 8, 2020 10:54
bkimmel
changed the title
bkimmel
added
v8.0.0
v7.9.0
release_note:skip
|
Pinging @elastic/endpoint-app-team (Feature:Resolver) |
|
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
michaelolo24
approved these changes
Jul 9, 2020
|
@marrasherrier provides her 👍 in absentia per Slack convo |
michaelolo24
reviewed
Jul 9, 2020
| title: i18n.translate('xpack.securitySolution.endpoint.resolver.panel.processDescList.path', { | ||
| defaultMessage: 'Path', | ||
| }), | ||
| title: 'process.executable', | ||
| description: processPath(processEvent), |
There was a problem hiding this comment.
double checking, but should the description still be processPath()
There was a problem hiding this comment.
Thanks for checking, yeah that's what they call it in ECS:
…-related-detail-panel
|
@elasticmachine merge upstream |
…-related-detail-panel
…-related-detail-panel
…ub.com/bkimmel/kibana into resolver/stylefix-related-detail-panel
kqualters-elastic
approved these changes
Jul 13, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 13, 2020
* master: (28 commits) skip flaky suite (elastic#71361) [Ingest Manager] Add UI to enroll standalone agent (elastic#71288) Node options from cfg file for production (elastic#62468) [APM] Improvements to the ML Settings page (elastic#71309) add old .chromium to gitignore to prevent it from being accidentally committed [Ingest Manager] Simplify add/edit package config (integration) form (elastic#71187) Ensure Other bucket works on scripted fields. (elastic#71329) [APM] Anomaly detection setup link with alert if job doesn't exist (elastic#71229) [APM] Anomaly detection integration with transaction duration chart (elastic#71230) inclusive language (elastic#71438) [Ingest Manager] During fleet setup create an enrollment for every config (elastic#71308) Improvements to our developer guide (elastic#67764) [SIEM][Detections] Fixes index patterns order (elastic#71270) [Metrics + Logs UI] Add test for logs and metrics telemetry (elastic#70858) [Maps] Inclusive language (elastic#71427) [Logs UI] Unskip log highlight api integration test (elastic#71058) [Security_Solution][Resolver] Style adjustments per UX (elastic#71179) [Functional test] Increase the timeout to click new vis function (elastic#71226) [Discover] Migrate async import of embeddable factory to actual embeddable (elastic#70920) fix overflow (elastic#70723) ...
bkimmel
added a commit
that referenced
this pull request
Jul 14, 2020
💔 Build Failed
Failed CI Steps
Build metrics
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts style concerns at the direction of the Security Design team per issues enumerated as
from:
find related screenshots / discussion with design team on issue