Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/pm] log levels #68203

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jun 4, 2020

@kbn/pm does not currently support log levels, it focuses on making the log output pretty and readable, but I think it is currently putting too much information in people's faces constantly and that most people don't really know or care about most of what it's saying. Additionally, I'd like to experiment with automatically bootstrapping on yarn start, and would like to clean up the log output a bit before doing that.

The new logging output will look familiar, it's using the same utilitarian ToolingLog format that we use elsewhere:

image

For those who do want more info from yarn kbn bootstrap, checkout the --debug level, I suspect you'll find it has everything you need.

@spalger spalger force-pushed the implement/kbn-pm/log-levels branch from 216de1f to 9bee775 Compare June 4, 2020 19:27
@spalger spalger added 0sp Team:Operations Team label for Operations Team v7.8.1 v7.9.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes and removed 0sp labels Jun 4, 2020
@spalger spalger marked this pull request as ready for review June 4, 2020 21:29
@spalger spalger requested a review from a team as a code owner June 4, 2020 21:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger mentioned this pull request Jun 4, 2020
15 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested

@spalger spalger merged commit ab226f0 into elastic:master Jun 8, 2020
@spalger spalger deleted the implement/kbn-pm/log-levels branch June 8, 2020 22:53
spalger pushed a commit to spalger/kibana that referenced this pull request Jun 8, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	packages/kbn-pm/dist/index.js
#	renovate.json5
spalger pushed a commit to spalger/kibana that referenced this pull request Jun 8, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	packages/kbn-pm/dist/index.js
#	renovate.json5
spalger added a commit that referenced this pull request Jun 9, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
spalger added a commit that referenced this pull request Jun 9, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants