-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kbn/pm] log levels #68203
Merged
Merged
[kbn/pm] log levels #68203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
implement/kbn-pm/log-levels
branch
from
June 4, 2020 19:27
216de1f
to
9bee775
Compare
spalger
added
0sp
Team:Operations
Team label for Operations Team
v7.8.1
v7.9.0
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
and removed
0sp
labels
Jun 4, 2020
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
tylersmalley
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - tested
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jun 8, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # packages/kbn-pm/dist/index.js # renovate.json5
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jun 8, 2020
Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # packages/kbn-pm/dist/index.js # renovate.json5
spalger
added a commit
that referenced
this pull request
Jun 9, 2020
spalger
added a commit
that referenced
this pull request
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.8.1
v7.9.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kbn/pm
does not currently support log levels, it focuses on making the log output pretty and readable, but I think it is currently putting too much information in people's faces constantly and that most people don't really know or care about most of what it's saying. Additionally, I'd like to experiment with automatically bootstrapping onyarn start
, and would like to clean up the log output a bit before doing that.The new logging output will look familiar, it's using the same utilitarian
ToolingLog
format that we use elsewhere:For those who do want more info from
yarn kbn bootstrap
, checkout the--debug
level, I suspect you'll find it has everything you need.