Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/pm] log levels #68203

Merged
merged 2 commits into from
Jun 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-dev-utils/src/tooling_log/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@

export { ToolingLog } from './tooling_log';
export { ToolingLogTextWriter, ToolingLogTextWriterConfig } from './tooling_log_text_writer';
export { pickLevelFromFlags, parseLogLevel, LogLevel } from './log_levels';
export { pickLevelFromFlags, parseLogLevel, LogLevel, ParsedLogLevel } from './log_levels';
export { ToolingLogCollectingWriter } from './tooling_log_collecting_writer';
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@
*/

import { ToolingLogTextWriter } from './tooling_log_text_writer';
import { LogLevel } from './log_levels';

export class ToolingLogCollectingWriter extends ToolingLogTextWriter {
messages: string[] = [];

constructor() {
constructor(level: LogLevel = 'verbose') {
super({
level: 'verbose',
level,
writeTo: {
write: (msg) => {
// trim trailing new line
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export interface ToolingLogTextWriterConfig {

function shouldWriteType(level: ParsedLogLevel, type: MessageTypes) {
if (type === 'write') {
return true;
return level.name !== 'silent';
}

return Boolean(level.flags[type === 'success' ? 'info' : type]);
Expand Down
Loading