Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM][Detections Engine] - Exceptions viewer cleanup #68651

Merged
merged 7 commits into from
Jun 10, 2020
Merged

[SIEM][Detections Engine] - Exceptions viewer cleanup #68651

merged 7 commits into from
Jun 10, 2020

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Jun 9, 2020 •
edited
Loading

Summary

This PR is a follow up to #68027 where some feedback didn't make it in. It cleans up the and_or_badge component, updates some css, and cleans up stories.

Screen Shot 2020-06-09 at 9 48 46 AM

Checklist

@yctercero yctercero requested review from a team as code owners June 9, 2020 13:56
@yctercero yctercero self-assigned this Jun 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@yctercero yctercero mentioned this pull request Jun 9, 2020
Merged
5 tasks
rylnd
rylnd approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I appreciate you following up on my late feedback.

...plugins/security_solution/public/common/components/exceptions/__examples__/index.stories.tsx Outdated Show resolved Hide resolved
...ugins/security_solution/public/common/components/and_or_badge/__examples__/index.stories.tsx Show resolved Hide resolved
...k/plugins/security_solution/public/common/components/exceptions/viewer/exception_details.tsx Outdated Show resolved Hide resolved
...plugins/security_solution/public/common/components/exceptions/__examples__/index.stories.tsx Outdated Show resolved Hide resolved
...k/plugins/security_solution/public/common/components/exceptions/viewer/exception_details.tsx Outdated Show resolved Hide resolved
rylnd
rylnd reviewed Jun 9, 2020
View reviewed changes
...k/plugins/security_solution/public/common/components/exceptions/viewer/exception_entries.tsx Outdated
@@ -134,7 +134,7 @@ const ExceptionEntriesComponent = ({
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexItem>
<EuiFlexItem>
<EuiFlexItem grow={false}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What caused this change, here? I couldn't see it having any effect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a matter of the buttons floating to the the top of the container when the left description list was long and the number of exceptions were not.

Here's a before:
Screen Shot 2020-06-09 at 6 50 39 PM

And after:
Screen Shot 2020-06-09 at 9 48 46 AM

@rylnd
Copy link
Contributor

rylnd commented Jun 9, 2020

A few style issues I just noticed:

  1. At smaller widths the RoundedBadge is broken:

Storybook

2. Text is wrapping for longer fields. This might be expected or wanted, but truncation might be a "cleaner" solution.

Storybook

@yctercero
Copy link
Contributor Author

A few style issues I just noticed:

  1. At smaller widths the RoundedBadge is broken:
    (See image in original comment)

  2. Text is wrapping for longer fields. This might be expected or wanted, but truncation might be a "cleaner" solution.
    (See image in original comment)

Thanks @rylnd for pointing these out! I went ahead and 1) removed the and badge on smaller sizes (I can follow up with UX on this) and 2) fixed the text wrapping.

Screen Shot 2020-06-09 at 6 48 46 PM

Screen Shot 2020-06-09 at 6 48 37 PM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit 8377181 into elastic:master Jun 10, 2020
yctercero added a commit to yctercero/kibana that referenced this pull request Jun 10, 2020
@yctercero
[SIEM][Detections Engine] - Exceptions viewer cleanup (elastic#68651)
318147a 
### Summary

This PR is a follow up to elastic#68027 where some feedback didn't make it in. It cleans up the and_or_badge component, updates some css, and cleans up stories.
@yctercero yctercero mentioned this pull request Jun 10, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 10, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
f56a849 
* master:
  [Ingest Manager] Document fleet configuration flags (elastic#66736)
  [Metrics UI] Fix fatal error when no data is available for Metric Threshold Alerts (elastic#68678)
  [SIEM][Detections Engine] - Exceptions viewer cleanup (elastic#68651)
  [SIEM] Fixes flyout flaky test (elastic#68683)
  [SIEM] Cypress renaming (elastic#68659)
yctercero added a commit that referenced this pull request Jun 10, 2020
@yctercero
[SIEM][Detections Engine] - Exceptions viewer cleanup (#68651) (#68755)
bcab846 
### Summary

This PR is a follow up to #68027 where some feedback didn't make it in. It cleans up the and_or_badge component, updates some css, and cleans up stories.
@yctercero yctercero deleted the exceptions-viewer-followup branch October 14, 2020 12:02
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

Assignees

@yctercero yctercero

Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yctercero @elasticmachine @rylnd @kibanamachine @MindyRS