Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Fix fatal error when no data is available for Metric Threshold Alerts #68678

Merged

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Jun 9, 2020

Summary

This PR fixes a fatal error with the Metric Threshold Alerts in the central management UI when there is no data available. This also adds i18n support for the error message.

Jun-09-2020 12-34-07

Testing

  1. Start ES and Kibana without any Metricbeat data
  2. Go to central management UI for Alerts & Actions
  3. Create a new alert, pick metric threshold alert
  4. You should get a message that says "Oops, no chart data available"

@simianhacker simianhacker added release_note:fix Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v7.8.1 labels Jun 9, 2020
@simianhacker simianhacker requested a review from a team as a code owner June 9, 2020 17:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker merged commit 951114d into elastic:master Jun 10, 2020
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jun 10, 2020
…eshold Alerts (elastic#68678)

* [Metrics UI] Fix fatal error when no data is available for Metric
Threshold Alerts

* Adding i18n support for error message

* Adding test
simianhacker added a commit to simianhacker/kibana that referenced this pull request Jun 10, 2020
…eshold Alerts (elastic#68678)

* [Metrics UI] Fix fatal error when no data is available for Metric
Threshold Alerts

* Adding i18n support for error message

* Adding test
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 10, 2020
* master:
  [Ingest Manager] Document fleet configuration flags (elastic#66736)
  [Metrics UI] Fix fatal error when no data is available for Metric Threshold Alerts (elastic#68678)
  [SIEM][Detections Engine] - Exceptions viewer cleanup (elastic#68651)
  [SIEM] Fixes flyout flaky test (elastic#68683)
  [SIEM] Cypress renaming (elastic#68659)
simianhacker added a commit that referenced this pull request Jun 10, 2020
…eshold Alerts (#68678) (#68758)

* [Metrics UI] Fix fatal error when no data is available for Metric
Threshold Alerts

* Adding i18n support for error message

* Adding test
simianhacker added a commit that referenced this pull request Jun 10, 2020
…ic Threshold Alerts (#68678) (#68759)

* [Metrics UI] Fix fatal error when no data is available for Metric Threshold Alerts (#68678)

* [Metrics UI] Fix fatal error when no data is available for Metric
Threshold Alerts

* Adding i18n support for error message

* Adding test

* Fixing tests
@simianhacker simianhacker deleted the fix-metric-threshold-alerts-no-data branch April 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Metrics UI Metrics UI feature release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.8.1 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants