Fix url overflow error UI in 7.8 #68670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdover
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Jun 10, 2020
| @@ -42,6 +42,7 @@ import 'uiExports/shareContextMenuExtensions'; | |||
| import 'uiExports/interpreter'; | |||
|
|
|||
| import 'ui/autoload/all'; | |||
| import 'ui/error_url_overflow'; | |||
There was a problem hiding this comment.
Are we sure these 3 imports are enough and that the feature isn't used elsewhere?
There was a problem hiding this comment.
To be honest, no. But AFAIK users only hit this in Dashboard, Vizualize, and Timelion in practice, so this seems like a good enough / lowest-risk solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The fix for #67458 in 7.8 is a bit different in that we just need to ensure that the route is imported. This eliminates the redirect loop seen in the issue.
Ideally this route would be registered in the kibana_legacy code itself, but that would be a riskier change for a post-FF fix and is not necessary for 7.9+.