Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[add data] Source record UI changes #6992

Merged
merged 3 commits into from
Apr 20, 2016
Merged

[add data] Source record UI changes #6992

merged 3 commits into from
Apr 20, 2016

Conversation

BigFunger
Copy link
Contributor

Depends on #6990

  • Removes the select box from the source data directive
  • Changes the behavior of the next/previous record buttons to loop through collection instead of stopping at the beginning and end
  • Moves the source-data directive into the Pipeline-output directive
  • Removes the expand/collapse links from the pipeline output

@BigFunger BigFunger added review Feature:Add Data Add Data and sample data feature on Home labels Apr 20, 2016
@Bargs
Copy link
Contributor

Bargs commented Apr 20, 2016

This also fixes #6618

Bargs
Bargs reviewed Apr 20, 2016
View reviewed changes
...na/public/settings/sections/indices/add_data_steps/pipeline_setup/views/pipeline_output.html
<source-data
sample="sample"
samples="samples"
sample="sample"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample gets repeated twice

@Bargs
Copy link
Contributor

Bargs commented Apr 20, 2016

Remove the duplicate sample parameter and this LGTM.

@Bargs Bargs assigned BigFunger and unassigned Bargs Apr 20, 2016
@BigFunger BigFunger mentioned this pull request Apr 20, 2016
Merged
@BigFunger BigFunger merged commit 398747b into elastic:feature/ingest Apr 20, 2016
@lgestc lgestc mentioned this pull request Jul 12, 2023
Closed
jbudz pushed a commit that referenced this pull request Aug 14, 2023
@1Copenut @tkajtoch
@cee-chen @drewdaemon
Upgrade EUI to v86.0.0 (#163088)
83d9644 
`85.1.0` ➡️ `86.0.0`

⚠️ The biggest change in this PR is migrating the `react-beautiful-dnd`
dependency to it's open-source forked successor, `@hello-pangea/dnd`.
This new fork has better typescript support and additionally supports
both React 17 and React 18.

## [`86.0.0`](https://github.com/elastic/eui/tree/v86.0.0)

- Added React 18 support (StrictMode not yet supported).
([#7012](elastic/eui#7012))

**Deprecations**

- Deprecated `euiPaletteComplimentary`; Use `euiPaletteComplementary`
instead. ([#6992](elastic/eui#6992))

**Breaking changes**

- Replaced the underlying drag-and-drop library from
`react-beautiful-dnd` to its fork `@hello-pangea/dnd`
([#7012](elastic/eui#7012))
([#7012](elastic/eui#7012))
- No code updates are needed if using only `<EuiDragDropContext>`,
`<EuiDroppable>` and `<EuiDraggable>` with no direct imports from
`react-beautiful-dnd`. In case you were importing things from
`react-beautiful-dnd` and using them together with EUI components, you
need to switch to `@hello-pangea/dnd` which has cross-compatible API.

---------

Co-authored-by: Tomasz Kajtoch <tomasz.kajtoch@elastic.co>
Co-authored-by: Tomasz Kajtoch <tomek@kajto.ch>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Drew Tate <andrew.tate@elastic.co>
bryce-b pushed a commit that referenced this pull request Aug 22, 2023
@1Copenut @tkajtoch
@cee-chen @drewdaemon @bryce-b
Upgrade EUI to v86.0.0 (#163088)
3e052f2 
`85.1.0` ➡️ `86.0.0`

⚠️ The biggest change in this PR is migrating the `react-beautiful-dnd`
dependency to it's open-source forked successor, `@hello-pangea/dnd`.
This new fork has better typescript support and additionally supports
both React 17 and React 18.

## [`86.0.0`](https://github.com/elastic/eui/tree/v86.0.0)

- Added React 18 support (StrictMode not yet supported).
([#7012](elastic/eui#7012))

**Deprecations**

- Deprecated `euiPaletteComplimentary`; Use `euiPaletteComplementary`
instead. ([#6992](elastic/eui#6992))

**Breaking changes**

- Replaced the underlying drag-and-drop library from
`react-beautiful-dnd` to its fork `@hello-pangea/dnd`
([#7012](elastic/eui#7012))
([#7012](elastic/eui#7012))
- No code updates are needed if using only `<EuiDragDropContext>`,
`<EuiDroppable>` and `<EuiDraggable>` with no direct imports from
`react-beautiful-dnd`. In case you were importing things from
`react-beautiful-dnd` and using them together with EUI components, you
need to switch to `@hello-pangea/dnd` which has cross-compatible API.

---------

Co-authored-by: Tomasz Kajtoch <tomasz.kajtoch@elastic.co>
Co-authored-by: Tomasz Kajtoch <tomek@kajto.ch>
Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Co-authored-by: Drew Tate <andrew.tate@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BigFunger BigFunger

Labels
Feature:Add Data Add Data and sample data feature on Home review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BigFunger @Bargs