[ML] Anomaly Detection: Annotations enhancements #70198

qn895 · 2020-06-29T13:56:42Z

Summary

This PR brings several enhancements from meta issue #69538

UI

Collapse the annotation panel by default in both Single Metric Viewer and Anomaly Explorer (with count for how many annotations)

Put anomalies content (charts and table) inside a EuiPanel

Show only user annotations by default

If there's no user annotations, it will show user (0) selected

Add a control to allow the user to also show the system generated annotations

Increase the width for Event so that it can show the full message
Add search bar
Add ability to filter annotations by partitioning field name/values
Filter the annotations table in the Single Metric Viewer to show annotations for the selected partitioning fields only
Add checkbox in the creation fly-out to indicate whether or not the annotation applies to only that partition or the whole job. This will record the following properties if they exist in the chartProperties:
- detector_index
- partition_field_value
- over_field_value
- by_field_value

Service

Update the annotations schema with the new fields listed in [ML] Make sure new fields .ml-annotations* work correctly #67748
Mark field event as user when a user creates an annotation (right now the event is null/empty)

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

[ML] Update snapshots [ML] Remove logs

[ML] Fix detector column name

…ions-enhancements # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

elasticmachine · 2020-06-30T18:09:34Z

Pinging @elastic/ml-ui (:ml)

walterra

Great progress overall! I added some questions.

One more suggestion here since it applies to the PR overall:
aggregations seemed to me like a very generic name for what we're now returning as part of the annotations results, it's quite a generic name and internal Elasticsearch concept. I wonder if we could rename it to somewhat more specific that reflects the type of data we're returning (types of events in this case so far)

x-pack/plugins/ml/common/types/annotations.ts

x-pack/plugins/ml/public/application/components/annotations/annotation_flyout/index.tsx

.../plugins/ml/public/application/components/annotations/annotations_table/annotations_table.js

x-pack/plugins/ml/server/models/annotation_service/annotation.ts

x-pack/plugins/ml/public/application/explorer/explorer.js

peteharverson · 2020-07-01T16:41:27Z

Might not be directly related to the changes in this PR, but the message here should be altered to say something like No annotations for the selected time range. There are annotations for this job, just not for the time period displayed in the main focus chart area (indication outside time range is covered by #54025).

.../plugins/ml/public/application/components/annotations/annotations_table/annotations_table.js

[ML] Refactor ANNOTATION_EVENT_USER & minor fixes

peteharverson · 2020-07-03T11:52:28Z

Not needed for this PR, but a nice follow-up would be to allow filtering from the partitioning field cells in the annotations table in the Anomaly Explorer. Here I wanted to quickly add a filter for the 193.106.172.144 mentioned in the annotation:

…ions-enhancements # Conflicts: # x-pack/plugins/ml/public/application/explorer/actions/load_explorer_data.ts # x-pack/plugins/ml/public/application/explorer/explorer.js # x-pack/plugins/ml/public/application/explorer/explorer_utils.js # x-pack/plugins/ml/public/application/explorer/reducers/explorer_reducer/reducer.ts # x-pack/plugins/ml/public/application/explorer/reducers/explorer_reducer/state.ts

- Add partitioning fields & detector to annotation flyout - Fix annotation layout overlay in AE - Add direct link to SMV with partitioning fields in detector - Update width for partitioning columns - Show all partitioning columns for both SMV and AE - Fix bug with annotation not editable by finding the original annotation

- When updating system generated annotation, persist the `event` field

.../plugins/ml/public/application/components/annotations/annotations_table/annotations_table.js

…ayed_data

qn895 · 2020-07-13T04:07:33Z

@elasticmachine merge upstream

qn895 · 2020-07-13T14:02:52Z

@elasticmachine merge upstream

…ions-enhancements # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

peteharverson

Tested latest changes and LGTM

walterra

LGTM

…ions-enhancements # Conflicts: # x-pack/plugins/ml/server/models/results_service/get_partition_fields_values.ts

kibanamachine · 2020-07-14T17:18:43Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 00b6c88

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
ml	390	+1	389

History

💚 Build #61231 succeeded ad7a947
💔 Build #61211 failed 4871783
💚 Build #60880 succeeded 687fed9
💔 Build #60426 failed 0e24cb3
💔 Build #60343 failed 02024e5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

qn895 added 3 commits June 28, 2020 21:50

[ML] Improve Annotations

ff3f180

[ML] Update snapshots [ML] Remove logs

[ML] Clean up logs & update snapshot

9ffddf3

[ML] Add unique ID

e517350

qn895 added enhancement New value added to drive a business result :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.9.0 labels Jun 29, 2020

qn895 self-assigned this Jun 29, 2020

qn895 added 6 commits June 29, 2020 10:04

[ML] Add user(0) if no bucket for user found

20ce417

[ML] Add dynamic columns to annotation table

2501b5f

[ML] Refactor unique aggregations to bundle with getAnnotations

e0ce77f

[ML] Fix type issue & aria obj warnings

f96e042

[ML] Fix detector column name

[ML] Update snapshot for annotation_table

ffd474a

qn895 requested review from peteharverson and walterra June 30, 2020 18:08

qn895 added release_note:enhancement and removed enhancement New value added to drive a business result labels Jun 30, 2020

qn895 marked this pull request as ready for review June 30, 2020 18:09

qn895 requested a review from a team as a code owner June 30, 2020 18:09

walterra reviewed Jul 1, 2020

View reviewed changes

[ML] Add EUI panel around Annotations in Anomaly Explorer

2ee31d4

peteharverson reviewed Jul 1, 2020

View reviewed changes

x-pack/plugins/ml/public/application/explorer/explorer.js Outdated Show resolved Hide resolved

peteharverson reviewed Jul 1, 2020

View reviewed changes

x-pack/plugins/ml/public/application/explorer/explorer.js Outdated Show resolved Hide resolved

peteharverson reviewed Jul 1, 2020

View reviewed changes

.../plugins/ml/public/application/components/annotations/annotations_table/annotations_table.js Outdated Show resolved Hide resolved

qn895 changed the title ~~[ML] WIP Anomaly Detection: Annotations enhancements~~ [ML] Anomaly Detection: Annotations enhancements Jul 1, 2020

[ML] Refactor ANNOTATION_EVENT_USER & minor fixes

36a5a44

[ML] Refactor ANNOTATION_EVENT_USER & minor fixes

qn895 added 3 commits July 8, 2020 14:40

[ML] Update snapshot, fix i18n, persist event field when editing

e57889f

- When updating system generated annotation, persist the `event` field

peteharverson reviewed Jul 9, 2020

View reviewed changes

.../plugins/ml/public/application/components/annotations/annotations_table/annotations_table.js Outdated Show resolved Hide resolved

peteharverson reviewed Jul 9, 2020

View reviewed changes

.../plugins/ml/public/application/components/annotations/annotations_table/annotations_table.js Show resolved Hide resolved

qn895 added 4 commits July 9, 2020 10:50

[ML] Remove partitions if apply to series is unchecked

dfe3950

[ML] Dynamic partition columns for SMV & default query to include del…

aa98817

…ayed_data

[ML] Fix annotation table in job list not having terms

02024e5

[ML] Change SMV annotations to only show series + non-partitioned

0e24cb3

Merge branch 'master' into transform-annotations-enhancements

687fed9

qn895 requested a review from alvarezmelissa87 July 13, 2020 14:09

qn895 added 5 commits July 13, 2020 12:54

[ML] Fix issue with EUI upgrade and current_series table

4871783

[ML] Update snapshot for annotations_table

ad7a947

peteharverson approved these changes Jul 14, 2020

View reviewed changes

walterra approved these changes Jul 14, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into transform-annotat…

00b6c88

…ions-enhancements # Conflicts: # x-pack/plugins/ml/server/models/results_service/get_partition_fields_values.ts

qn895 merged commit c24f180 into elastic:master Jul 14, 2020

qn895 deleted the transform-annotations-enhancements branch July 14, 2020 17:36

qn895 mentioned this pull request Jul 14, 2020

[7.x] [ML] Anomaly Detection: Annotations enhancements (#70198) #71707

Merged

qn895 added a commit to qn895/kibana that referenced this pull request Jul 14, 2020

[ML] Anomaly Detection: Annotations enhancements (elastic#70198)

c55659f

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

peteharverson mentioned this pull request Jul 15, 2020

[ML] Make sure new fields .ml-annotations* work correctly #67748

Closed

qn895 mentioned this pull request Nov 11, 2020

[ML] Performance improvements to annotations editing in Single Metric Viewer & buttons placement #83216

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Anomaly Detection: Annotations enhancements #70198

[ML] Anomaly Detection: Annotations enhancements #70198

qn895 commented Jun 29, 2020 •

edited

Loading

elasticmachine commented Jun 30, 2020

walterra left a comment

peteharverson commented Jul 1, 2020

peteharverson commented Jul 3, 2020

qn895 commented Jul 13, 2020

qn895 commented Jul 13, 2020

peteharverson left a comment

walterra left a comment

kibanamachine commented Jul 14, 2020

[ML] Anomaly Detection: Annotations enhancements #70198

[ML] Anomaly Detection: Annotations enhancements #70198

Conversation

qn895 commented Jun 29, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Jun 30, 2020

walterra left a comment

Choose a reason for hiding this comment

peteharverson commented Jul 1, 2020

peteharverson commented Jul 3, 2020

qn895 commented Jul 13, 2020

qn895 commented Jul 13, 2020

peteharverson left a comment

Choose a reason for hiding this comment

walterra left a comment

Choose a reason for hiding this comment

kibanamachine commented Jul 14, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

History

qn895 commented Jun 29, 2020 •

edited

Loading