[ML] Handling data recognizer saved object errors #72447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
requested review from
peteharverson,
darnautov,
qn895 and
alvarezmelissa87
jgowdyelastic
added
:ml
bug
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Jul 20, 2020
x-pack/plugins/ml/server/models/data_recognizer/data_recognizer.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
qn895
reviewed
Jul 21, 2020
| @@ -55,6 +55,11 @@ export const KibanaObjects: FC<KibanaObjectItemProps> = memo( | |||
| <EuiText size="s" color={exists ? 'subdued' : 'secondary'}> | |||
| {title} | |||
| </EuiText> | |||
| {success === false && error !== undefined && ( | |||
| <EuiText size="xs" color="danger"> | |||
| {error.message} | |||
There was a problem hiding this comment.
Might be worth using extractErrorMessage util function in common, but I'm guessing we know for sure the errorObj will always have the message property in this case.
There was a problem hiding this comment.
this error isn't in a format that is recognised by extractErrorMessage
|
LGTM other than one comment about handling |
qn895
approved these changes
Jul 21, 2020
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jul 21, 2020
* [ML] Handling data recognizer saved object errors * adding text for unknown errors * fixing typos
This was referenced Jul 21, 2020
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jul 21, 2020
* [ML] Handling data recognizer saved object errors * adding text for unknown errors * fixing typos
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 21, 2020
* master: [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576) [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563) Move manifest packageConfig mocks into security_solution plugin (elastic#72527) [QA][Code Coverage] Fixup Team Assignment (elastic#72467) [docs] remove references to tile map visualization in supported aggregations (elastic#72493) [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633) Only check that the event ids are the same in arrays (elastic#72624) Add doc titles to ES UI apps (elastic#71045) Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347) [APM] Disable flaky rum e2e’s (elastic#72614) Applying tiny fix from 72532 to main branch (elastic#72533) [APM] Update script with new roles/users (elastic#72599) [Security Solution] Add margin (elastic#72542) Migrated fixed_scroll karma tests to jest (elastic#72258) [ML] Handling data recognizer saved object errors (elastic#72447) [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310) [Task Manager] Batches the update operations in Task Manager (elastic#71470)
jgowdyelastic
added a commit
that referenced
this pull request
Jul 22, 2020
jgowdyelastic
added a commit
that referenced
this pull request
Jul 22, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 22, 2020
…feature-privileges * alerting/consumer-based-rbac: [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576) [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563) renamed variable to make it clear the SO client is unsecured Move manifest packageConfig mocks into security_solution plugin (elastic#72527) [QA][Code Coverage] Fixup Team Assignment (elastic#72467) [docs] remove references to tile map visualization in supported aggregations (elastic#72493) [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633) Only check that the event ids are the same in arrays (elastic#72624) includes hidden params type in SO client Add doc titles to ES UI apps (elastic#71045) Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347) [APM] Disable flaky rum e2e’s (elastic#72614) Applying tiny fix from 72532 to main branch (elastic#72533) [APM] Update script with new roles/users (elastic#72599) [Security Solution] Add margin (elastic#72542) Migrated fixed_scroll karma tests to jest (elastic#72258) [ML] Handling data recognizer saved object errors (elastic#72447) [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310) [Task Manager] Batches the update operations in Task Manager (elastic#71470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up a module, ff the user doesn't have permission to create dashboards, saved searches or visualizations, the errors from kibana need to be passed back to the UI and displayed.
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately