[Security Solution] Add margin #72542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkimmel
approved these changes
Jul 20, 2020
bkimmel
added
v7.9.0
release_note:skip
bkimmel
reviewed
Jul 21, 2020
| @@ -410,7 +410,7 @@ const UnstyledProcessEventDot = React.memo( | |||
| alignSelf: 'flex-start', | |||
| background: colorMap.resolverBackground, | |||
| display: `${isShowingEventActions ? 'flex' : 'none'}`, | |||
| margin: 0, | |||
| margin: '2px 0 0 0', | |||
There was a problem hiding this comment.
❔ This kicks it down a hairline, right? I got it to stop doing the rendering thing (But I didn't test it very much) by setting contain: layout on the button above. Maybe something to keep in mind later if someone wants to nudge it back where it was. It's a weird issue and AFAICT one of those things that "shouldn't happen" by the book.
There was a problem hiding this comment.
Yea it does. The padding at the top of the popover was 2px so I added the margin to account for that. Yea, it shouldn't because even with the padding, it should still respect each elements space in the layout. 🤷♂️
michaelolo24
added
Team:Endpoint Data Visibility
|
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
michaelolo24
added a commit
to michaelolo24/kibana
that referenced
this pull request
Jul 21, 2020
michaelolo24
added a commit
to michaelolo24/kibana
that referenced
this pull request
Jul 21, 2020
michaelolo24
added a commit
that referenced
this pull request
Jul 21, 2020
michaelolo24
added a commit
that referenced
this pull request
Jul 21, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 21, 2020
* master: [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576) [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563) Move manifest packageConfig mocks into security_solution plugin (elastic#72527) [QA][Code Coverage] Fixup Team Assignment (elastic#72467) [docs] remove references to tile map visualization in supported aggregations (elastic#72493) [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633) Only check that the event ids are the same in arrays (elastic#72624) Add doc titles to ES UI apps (elastic#71045) Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347) [APM] Disable flaky rum e2e’s (elastic#72614) Applying tiny fix from 72532 to main branch (elastic#72533) [APM] Update script with new roles/users (elastic#72599) [Security Solution] Add margin (elastic#72542) Migrated fixed_scroll karma tests to jest (elastic#72258) [ML] Handling data recognizer saved object errors (elastic#72447) [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310) [Task Manager] Batches the update operations in Task Manager (elastic#71470)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 22, 2020
…feature-privileges * alerting/consumer-based-rbac: [Security Solution][Timeline] Add Empty view to the Timelines page (elastic#72576) [Security Solution][Resolver] Show process detail panel when clicking a process node (elastic#72563) renamed variable to make it clear the SO client is unsecured Move manifest packageConfig mocks into security_solution plugin (elastic#72527) [QA][Code Coverage] Fixup Team Assignment (elastic#72467) [docs] remove references to tile map visualization in supported aggregations (elastic#72493) [ci][apm-ui] fix argument name for disabling pr comments (elastic#72633) Only check that the event ids are the same in arrays (elastic#72624) includes hidden params type in SO client Add doc titles to ES UI apps (elastic#71045) Add Upgrade Assistant API integration test to ensure the reindex operation saved object can handle immense error messages (elastic#72347) [APM] Disable flaky rum e2e’s (elastic#72614) Applying tiny fix from 72532 to main branch (elastic#72533) [APM] Update script with new roles/users (elastic#72599) [Security Solution] Add margin (elastic#72542) Migrated fixed_scroll karma tests to jest (elastic#72258) [ML] Handling data recognizer saved object errors (elastic#72447) [Monitoring] Fix the messaging around needing TLS enabled (elastic#72310) [Task Manager] Batches the update operations in Task Manager (elastic#71470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the button overlap
Checklist
Delete any items that are not applicable to this PR.
For maintainers