Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README files for Kibana app plugins #74277

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Conversation

timroes
Copy link
Contributor

@timroes timroes commented Aug 4, 2020

Adds Readme files for all Kibana App plugins to appear on https://www.elastic.co/guide/en/kibana/master/code-exploration.html.

Also removed one no longer existing folder from the CODEOWNERS file (I thought otherwise noone wants to ever setup a separate PR for that one line :D)

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 4, 2020
@timroes timroes requested review from flash1293 and a team August 4, 2020 17:19
@timroes timroes requested a review from a team as a code owner August 4, 2020 17:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contains the code review: LGTM!

timroes and others added 2 commits August 5, 2020 09:41
Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timroes timroes merged commit f9fc83f into elastic:master Aug 5, 2020
@timroes timroes deleted the plugin-readmes branch August 5, 2020 12:29
timroes pushed a commit to timroes/kibana that referenced this pull request Aug 5, 2020
* Add README files for Kibana app plugins

* Update src/plugins/timelion/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* Update src/plugins/vis_type_vislib/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
# Conflicts:
#	.github/CODEOWNERS
@mshustov mshustov mentioned this pull request Aug 5, 2020
timroes pushed a commit to timroes/kibana that referenced this pull request Aug 5, 2020
* Add README files for Kibana app plugins

* Update src/plugins/timelion/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* Update src/plugins/vis_type_vislib/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
# Conflicts:
#	.github/CODEOWNERS
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 5, 2020
* master:
  update docs (elastic#74364)
  [Ingest Node Pipelines] Refactor pipeline simulator code (elastic#72328)
  Add README files for Kibana app plugins (elastic#74277)
  [APM] Average for transaction error rate includes null values (elastic#74345)
  [Ingest Manager] Adjust dataset aggs to use datastream fields instead (elastic#74342)
timroes pushed a commit that referenced this pull request Aug 5, 2020
…74364) (#74368)

* Add README files for Kibana app plugins (#74277)

* Add README files for Kibana app plugins

* Update src/plugins/timelion/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* Update src/plugins/vis_type_vislib/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
# Conflicts:
#	.github/CODEOWNERS

* update docs (#74364)

* Remove CODEOWNERS

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants