Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs #74364

Merged
merged 1 commit into from
Aug 5, 2020
Merged

update docs #74364

merged 1 commit into from
Aug 5, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Aug 5, 2020

Summary

Fix the master. Update docs.
Culprit #74277

@mshustov mshustov added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 5, 2020
@mshustov
Copy link
Contributor Author

mshustov commented Aug 5, 2020

@elastic/kibana-operations Has it happened because we don't run CI checks for PR with the docs only changes?

@mshustov mshustov merged commit 8759646 into elastic:master Aug 5, 2020
@mshustov mshustov deleted the master-hotfix-update-docs branch August 5, 2020 13:28
@timroes
Copy link
Contributor

timroes commented Aug 5, 2020

Sorry for that. Yes I think that was exactly what happened there, If we fail on other PRs due to things that could be changed in Markdown only, I am pretty sure we should also run CI on those PRs properly too (despite that will be quit some pain still for docs only changes, so not sure if that detection could become somehow smarter). Will incorporate this PR into my backport.

timroes pushed a commit to timroes/kibana that referenced this pull request Aug 5, 2020
@mshustov @timroes
update docs (elastic#74364)
2f45688
@timroes timroes mentioned this pull request Aug 5, 2020
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

‼️ metrics were not reported for baseline [master@f9fc83f]. Try merging the upstream branch and trying again.

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 5, 2020
@gmmorris
Merge branch 'master' into alerting/refresh-on-deletion
d794d96 
* master:
  update docs (elastic#74364)
  [Ingest Node Pipelines] Refactor pipeline simulator code (elastic#72328)
  Add README files for Kibana app plugins (elastic#74277)
  [APM] Average for transaction error rate includes null values (elastic#74345)
  [Ingest Manager] Adjust dataset aggs to use datastream fields instead (elastic#74342)
@spalger spalger mentioned this pull request Aug 5, 2020
Merged
@spalger
Copy link
Contributor

spalger commented Aug 5, 2020 •
edited
Loading

Adding a check to the logic in our pipeline to check for changes in plugin readme files and run CI if any of those have changed. #74388

timroes pushed a commit that referenced this pull request Aug 5, 2020
@mshustov
[7.x] Add README files for Kibana app plugins (#74277) | update docs (#…
94720bb 
…74364) (#74368)

* Add README files for Kibana app plugins (#74277)

* Add README files for Kibana app plugins

* Update src/plugins/timelion/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

* Update src/plugins/vis_type_vislib/README.md

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>

Co-authored-by: Matthias Wilhelm <ankertal@gmail.com>
# Conflicts:
#	.github/CODEOWNERS

* update docs (#74364)

* Remove CODEOWNERS

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshustov @timroes @kibanamachine @spalger