[Security Solution][Detections] Refactor ML calls for newest ML permissions #74582

rylnd · 2020-08-06T18:57:10Z

Summary

Addresses #73567.

ML Users (role: machine_learning_user) were previously able to invoke the ML Recognizer API, which we use to get not-yet-installed ML Jobs relevant to our index patterns. As of #64662 this is not true, and so we receive errors from components using the underlying hook, useSiemJobs.

To solve this I've created two separate hooks to replace useSiemJobs:

useSecurityJobs
- used on ML Popover
- includes uninstalled ML Jobs
- checks (and returns) isMlAdmin before fetching data
useInstalledSecurityJobs
- used on ML Jobs Dropdown and Anomalies Table
- includes only installed ML Jobs
- checks (and returns) isMlUser before fetching data

Note that we while we now receive the knowledge to do so, we do not always inform the user in the case of invalid permissions, and instead have the following behaviors:

User has insufficient license

ML Popover: shows an upgrade CTA
Anomalies Tables: show no data
Rule Creation: ML Rule option is disabled, shows upgrade CTA
Rule Details: ML Job Id is displayed as text

User is ML User

ML Popover: not shown
Anomalies Tables: show no data
Rule Creation: ML Rule option is disabled
Rule Details: ML Job Id is displayed as text

User is ML Admin

ML Popover: shown
Anomalies Tables: show data for installed ML Jobs
- This is the same as previous logic, but worth calling out that you can't view historical anomalies
Rule Creation: ML Rule option is enabled, all ML Jobs available
Rule Details: ML Job Id is displayed as hyperlink, job status badge shown

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

This is just some cleanup, this should be functionally equivalent. This does use the new toast service, however.

This is incredibly similar to the existing useSiemJobs hook, with the following exceptions: * Does not fetch data if the user is not an ML admin * Returns additional booleans: `isMlAdmin` and `isLicensed` * uses new toasts service

Our jobs summary call returns all installed jobs regardless of group; passing groups as jobIds does not perform group filtering. This adds a helper predicate function on which to filter these results, and updates tests accordingly.

This allows us to use this predicate on both JobSummary and MlSummaryJob until we can consolidate to the former.

* Replaces existing API call with pure version * Adds hook via useAsync * Moves types to the more general ml/ folder out of ml_popover/ The JobSummary type can be retrieved from the ml plugin eventually, but this is an intermediate step until I get there.

Unlike useSecurityJobs, which additionally: * fetches uninstalled jobs * requires ML Admin permissions useInstalledSecurityJobs: * fetches only installed jobs * requires ml User permissions This hook is a lightweight replacement for the more restrictive useSiemJobs in places like the alerts table and the ML Jobs dropdown.

This was mostly a dropin replacement for the remaining use cases; there were a few now-unnecessary `isInstalled` filters that were removed.

These are helpers for our new hook, not the old one.

This is no longer specific to the ml popover, nor has it been for quite a while.

We should not be maintaining our own type here. There were two small fixes needed to make this work: * export the anomaly job types from ml/public * change the auditMessage level value from a number to a string The latter seems to have been an error, as `auditMessage.level` comes back as a string, seemingly an enum. We treat it as an enum in our own plugin, but I'll leave it as a string for now within ml.

Conflicts: x-pack/plugins/security_solution/common/machine_learning/is_security_job.ts

* moves corresponding API mocks to new .mock format * the automock folder was actually getting in my way * Adds new mocks for our useAppToasts hook

We have this info here, best to leverage it.

This abstracts away any dealing with our raw capabilities response.

There's already a translation for this, no need for extra work here.

For now, we don't want to filter our dropdown to just installed jobs; that's a broader product decision that we'll circle back to.

rylnd · 2020-08-12T02:41:24Z

@elasticmachine merge upstream

kibanamachine · 2020-08-12T04:37:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 15f26ec

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
securitySolution	2035	+6	2029

async chunks size

id	value	diff	baseline
ml	7.9MB	-6.9KB	7.9MB
securitySolution	7.3MB	+8.3KB	7.3MB
total		+1.4KB

page load bundle size

id	value	diff	baseline
ml	505.6KB	+5.2KB	500.4KB
securitySolution	805.9KB	+83.0B	805.8KB
total		+5.3KB

History

💔 Build #67611 failed be0a06c
💔 Build #67586 failed 0459dd65977e53975721e4503537c8d3574a8f5b
💔 Build #67295 failed f7aa1fd
💔 Build #67091 failed 96f3608
💔 Build #67022 failed 62b479f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jgowdyelastic

ML changes LGTM

spong · 2020-08-12T22:18:55Z

...ck/plugins/security_solution/public/common/components/ml/anomaly/use_anomalies_table_data.ts

@@ -104,13 +100,13 @@ export const useAnomaliesTableData = ({
          }
        } catch (error) {
          if (isSubscribed) {
-            errorToToaster({ title: i18n.SIEM_TABLE_FETCH_FAILURE, error, dispatchToaster });
+            addError(error, { title: i18n.SIEM_TABLE_FETCH_FAILURE });


++ for refactoring to leverage useAppToasts, thanks!

spong · 2020-08-12T22:30:37Z

x-pack/plugins/security_solution/public/common/components/ml/hooks/use_get_jobs_summary.ts

+const _getJobsSummary = withOptionalSignal(getJobsSummary);
+
+export const useGetJobsSummary = () => useAsync(_getJobsSummary);


Really liking how the new composable hooks are turning out. Keeps the actual API request logic small and easy to grok, while making creating specific hooks like above super simple. Autocomplete is all 👍 too, so that's nice as well. Thanks for all the effort here @rylnd 🙂

spong · 2020-08-12T22:39:02Z

...gins/security_solution/public/common/components/ml/hooks/use_installed_security_jobs.test.ts

+    it('renders a toast error if the ML call fails', async () => {
+      (getJobsSummary as jest.Mock).mockRejectedValue('whoops');
+      const { waitForNextUpdate } = renderHook(() => useInstalledSecurityJobs());
+      await waitForNextUpdate();
+
+      expect(appToastsMock.addError).toHaveBeenCalledWith('whoops', {
+        title: 'Security job fetch failure',
+      });


We've had a gap in our coverage around the ML hooks for a long time, so awesome to see these tests! 🚀 🎉

spong · 2020-08-12T22:46:48Z

x-pack/plugins/security_solution/public/common/components/ml_popover/api.mock.ts

@@ -31,7 +31,7 @@ export const mockGroupsResponse: Group[] = [
  { id: 'suricata', jobIds: ['suricata_alert_rate'], calendarIds: [] },
 ];

-export const mockOpenedJob: JobSummary = {
+export const mockOpenedJob: MlSummaryJob = {


++ for moving to use the ML types. More safety here now 🙂

spong · 2020-08-12T22:52:19Z

x-pack/plugins/security_solution/public/common/components/ml_popover/hooks/use_security_jobs.ts

+ * ml_module (whether installed or not). Use the corresponding helper functions to filter the job
+ * list as necessary. E.g. installed jobs, running jobs, etc.
+ *
+ * NOTE: If the user is not an ml admin, jobs will be empty and isMlAdmin will be false.


nit: May be worth referencing useInstalledSecurityJobs as an alternate here for when the user is not an ml admin and we still need to fetch relevant jobs.

That's an excellent point, will do.

spong · 2020-08-12T22:53:27Z

x-pack/plugins/security_solution/public/common/components/ml_popover/hooks/use_security_jobs.ts

+  const [jobs, setJobs] = useState<SecurityJob[]>([]);
+  const [loading, setLoading] = useState(true);
+  const mlCapabilities = useMlCapabilities();
+  const [siemDefaultIndex] = useUiSetting$<string[]>(DEFAULT_INDEX_KEY);


Suggested change

const [siemDefaultIndex] = useUiSetting$<string[]>(DEFAULT_INDEX_KEY);

const [securitySolutionDefaultIndex] = useUiSetting$<string[]>(DEFAULT_INDEX_KEY);

And other references below.... 👋 SIEM

spong · 2020-08-12T23:12:02Z

x-pack/plugins/security_solution/public/common/components/ml_popover/types.ts

@@ -133,18 +111,18 @@ export interface CustomURL {
 }

 /**
- * Representation of an ML Job as used by the SIEM App -- a composition of ModuleJob and JobSummary
+ * Representation of an ML Job as used by the SIEM App -- a composition of ModuleJob and MlSummaryJob


Suggested change

* Representation of an ML Job as used by the SIEM App -- a composition of ModuleJob and MlSummaryJob

* Representation of an ML Job as used by the Security Solution App -- a composition of ModuleJob and MlSummaryJob

x-pack/plugins/security_solution/public/common/mock/kibana_core.ts

spong

Performed code review, and checked out locally and tested with multiple different user permissions from read_only, machine_learning_user and machine_learning_admin and all behavior has been as expected.

Left a couple nits for cleaning up some lingering siem references, but everything else looks great. Super clean code here, and love the new tests for the ML hooks -- really appreciate the attention to detail here @rylnd! LGTM! 👍 🎉

Note: In testing, @rylnd and I found an extra call to the getJobsSummary API on the Hosts page and it looks like there's a MatrixHistogram being rendered in the DOM above the Anomalies table, but it's not configured to the ML indices so it returns nothing and is not shown. Just some tech debt for us to clean up here it looks like.

…ssions (elastic#74582) ## Summary Addresses elastic#73567. ML Users (role: `machine_learning_user`) were previously able to invoke the ML Recognizer API, which we use to get not-yet-installed ML Jobs relevant to our index patterns. As of elastic#64662 this is not true, and so we receive errors from components using the underlying hook, `useSiemJobs`. To solve this I've created two separate hooks to replace `useSiemJobs`: * `useSecurityJobs` * used on ML Popover * includes uninstalled ML Jobs * checks (and returns) `isMlAdmin` before fetching data * `useInstalledSecurityJobs` * used on ML Jobs Dropdown and Anomalies Table * includes only installed ML Jobs * checks (and returns) `isMlUser` before fetching data Note that we while we now receive the knowledge to do so, we do not always inform the user in the case of invalid permissions, and instead have the following behaviors: #### User has insufficient license * ML Popover: shows an upgrade CTA * Anomalies Tables: show no data * Rule Creation: ML Rule option is disabled, shows upgrade CTA * Rule Details: ML Job Id is displayed as text #### User is ML User * ML Popover: not shown * Anomalies Tables: show no data * Rule Creation: ML Rule option is disabled * Rule Details: ML Job Id is displayed as text #### User is ML Admin * ML Popover: shown * Anomalies Tables: show data __for installed ML Jobs__ * This is the same as previous logic, but worth calling out that you can't view historical anomalies * Rule Creation: ML Rule option is enabled, all ML Jobs available * Rule Details: ML Job Id is displayed as hyperlink, job status badge shown ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)

…ssions (#74582) (#74919) ## Summary Addresses #73567. ML Users (role: `machine_learning_user`) were previously able to invoke the ML Recognizer API, which we use to get not-yet-installed ML Jobs relevant to our index patterns. As of #64662 this is not true, and so we receive errors from components using the underlying hook, `useSiemJobs`. To solve this I've created two separate hooks to replace `useSiemJobs`: * `useSecurityJobs` * used on ML Popover * includes uninstalled ML Jobs * checks (and returns) `isMlAdmin` before fetching data * `useInstalledSecurityJobs` * used on ML Jobs Dropdown and Anomalies Table * includes only installed ML Jobs * checks (and returns) `isMlUser` before fetching data Note that we while we now receive the knowledge to do so, we do not always inform the user in the case of invalid permissions, and instead have the following behaviors: #### User has insufficient license * ML Popover: shows an upgrade CTA * Anomalies Tables: show no data * Rule Creation: ML Rule option is disabled, shows upgrade CTA * Rule Details: ML Job Id is displayed as text #### User is ML User * ML Popover: not shown * Anomalies Tables: show no data * Rule Creation: ML Rule option is disabled * Rule Details: ML Job Id is displayed as text #### User is ML Admin * ML Popover: shown * Anomalies Tables: show data __for installed ML Jobs__ * This is the same as previous logic, but worth calling out that you can't view historical anomalies * Rule Creation: ML Rule option is enabled, all ML Jobs available * Rule Details: ML Job Id is displayed as hyperlink, job status badge shown ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) Co-authored-by: Ryland Herrick <ryalnd@gmail.com>

* master: (28 commits) [Task manager] Prevents edge case where already running tasks are reschedule every polling interval (elastic#74606) [Security Solution] Fix the status of timelines' bulk actions (elastic#74560) Data plugin: Suggested enhance pattern (elastic#74505) Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (elastic#74642) [Security Solution][lists] Adds tests for exception lists and items part 2 (elastic#74815) [Security Solution][Resolver] fix presentation role on edgeline (elastic#74869) [Security Solution][Detections] Refactor ML calls for newest ML permissions (elastic#74582) [bin/kibana-plugin] support KP plugins instead (elastic#74604) Reduce number of indexed fields in index pattern saved object (elastic#74817) [reporting] Pass along generic parameters in high-order route handler (elastic#74892) Migrated last pieces of legacy fixture code (elastic#74470) Empty index patterns page re-design (elastic#68819) [babel] coalese some versions to prevent breaking yarn install (elastic#74864) [Dashboard First] Decouple Attribute Service and By Value Embeddables (elastic#74302) Revert "[reporting] Pass along generic parameters in high-order route handler" (elastic#74891) [reporting] Pass along generic parameters in high-order route handler (elastic#74879) [src/dev/build] implement a getBuildNumber() mock (elastic#74881) [Enterprise Search] Add solution-level side navigation (elastic#74705) [DOCS] Canvas docs 7.9 refresh (elastic#74000) [Security Solution][Resolver]Enzyme test related events closing (elastic#74811) ...

…le-buffer-with-update-of-same-id * upstream/master: (37 commits) [Task manager] Prevents edge case where already running tasks are reschedule every polling interval (elastic#74606) [Security Solution] Fix the status of timelines' bulk actions (elastic#74560) Data plugin: Suggested enhance pattern (elastic#74505) Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (elastic#74642) [Security Solution][lists] Adds tests for exception lists and items part 2 (elastic#74815) [Security Solution][Resolver] fix presentation role on edgeline (elastic#74869) [Security Solution][Detections] Refactor ML calls for newest ML permissions (elastic#74582) [bin/kibana-plugin] support KP plugins instead (elastic#74604) Reduce number of indexed fields in index pattern saved object (elastic#74817) [reporting] Pass along generic parameters in high-order route handler (elastic#74892) Migrated last pieces of legacy fixture code (elastic#74470) Empty index patterns page re-design (elastic#68819) [babel] coalese some versions to prevent breaking yarn install (elastic#74864) [Dashboard First] Decouple Attribute Service and By Value Embeddables (elastic#74302) Revert "[reporting] Pass along generic parameters in high-order route handler" (elastic#74891) [reporting] Pass along generic parameters in high-order route handler (elastic#74879) [src/dev/build] implement a getBuildNumber() mock (elastic#74881) [Enterprise Search] Add solution-level side navigation (elastic#74705) [DOCS] Canvas docs 7.9 refresh (elastic#74000) [Security Solution][Resolver]Enzyme test related events closing (elastic#74811) ...

* upstream/master: (45 commits) [Metrics UI] Fix inventory footer misalignment (elastic#74707) Remove legacy optimizer (elastic#73154) Update design-specific GH code-owners (elastic#74877) skip test Reporting paginates content elastic#74922 [Metrics UI] Add Jest tests for alert previews (elastic#74890) Fixed tooltip (elastic#74074) [Ingest Pipelines] Processor forms for processors A-D (elastic#72849) [Observability] change ingest manager link (elastic#74928) [Task manager] Prevents edge case where already running tasks are reschedule every polling interval (elastic#74606) [Security Solution] Fix the status of timelines' bulk actions (elastic#74560) Data plugin: Suggested enhance pattern (elastic#74505) Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (elastic#74642) [Security Solution][lists] Adds tests for exception lists and items part 2 (elastic#74815) [Security Solution][Resolver] fix presentation role on edgeline (elastic#74869) [Security Solution][Detections] Refactor ML calls for newest ML permissions (elastic#74582) [bin/kibana-plugin] support KP plugins instead (elastic#74604) Reduce number of indexed fields in index pattern saved object (elastic#74817) [reporting] Pass along generic parameters in high-order route handler (elastic#74892) Migrated last pieces of legacy fixture code (elastic#74470) Empty index patterns page re-design (elastic#68819) ...

…ssions (elastic#74582) ## Summary Addresses elastic#73567. ML Users (role: `machine_learning_user`) were previously able to invoke the ML Recognizer API, which we use to get not-yet-installed ML Jobs relevant to our index patterns. As of elastic#64662 this is not true, and so we receive errors from components using the underlying hook, `useSiemJobs`. To solve this I've created two separate hooks to replace `useSiemJobs`: * `useSecurityJobs` * used on ML Popover * includes uninstalled ML Jobs * checks (and returns) `isMlAdmin` before fetching data * `useInstalledSecurityJobs` * used on ML Jobs Dropdown and Anomalies Table * includes only installed ML Jobs * checks (and returns) `isMlUser` before fetching data Note that we while we now receive the knowledge to do so, we do not always inform the user in the case of invalid permissions, and instead have the following behaviors: #### User has insufficient license * ML Popover: shows an upgrade CTA * Anomalies Tables: show no data * Rule Creation: ML Rule option is disabled, shows upgrade CTA * Rule Details: ML Job Id is displayed as text #### User is ML User * ML Popover: not shown * Anomalies Tables: show no data * Rule Creation: ML Rule option is disabled * Rule Details: ML Job Id is displayed as text #### User is ML Admin * ML Popover: shown * Anomalies Tables: show data __for installed ML Jobs__ * This is the same as previous logic, but worth calling out that you can't view historical anomalies * Rule Creation: ML Rule option is enabled, all ML Jobs available * Rule Details: ML Job Id is displayed as hyperlink, job status badge shown ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)

…ssions (#74582) (#75287) ## Summary Addresses #73567. ML Users (role: `machine_learning_user`) were previously able to invoke the ML Recognizer API, which we use to get not-yet-installed ML Jobs relevant to our index patterns. As of #64662 this is not true, and so we receive errors from components using the underlying hook, `useSiemJobs`. To solve this I've created two separate hooks to replace `useSiemJobs`: * `useSecurityJobs` * used on ML Popover * includes uninstalled ML Jobs * checks (and returns) `isMlAdmin` before fetching data * `useInstalledSecurityJobs` * used on ML Jobs Dropdown and Anomalies Table * includes only installed ML Jobs * checks (and returns) `isMlUser` before fetching data Note that we while we now receive the knowledge to do so, we do not always inform the user in the case of invalid permissions, and instead have the following behaviors: #### User has insufficient license * ML Popover: shows an upgrade CTA * Anomalies Tables: show no data * Rule Creation: ML Rule option is disabled, shows upgrade CTA * Rule Details: ML Job Id is displayed as text #### User is ML User * ML Popover: not shown * Anomalies Tables: show no data * Rule Creation: ML Rule option is disabled * Rule Details: ML Job Id is displayed as text #### User is ML Admin * ML Popover: shown * Anomalies Tables: show data __for installed ML Jobs__ * This is the same as previous logic, but worth calling out that you can't view historical anomalies * Rule Creation: ML Rule option is enabled, all ML Jobs available * Rule Details: ML Job Id is displayed as hyperlink, job status badge shown ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process) Co-authored-by: Ryland Herrick <ryalnd@gmail.com>

elasticmachine · 2021-09-23T14:27:42Z

Pinging @elastic/security-solution (Team: SecuritySolution)

rylnd added 14 commits August 5, 2020 14:11

Refactor ML Capabilities provider to leverage useAsync

7e7e013

This is just some cleanup, this should be functionally equivalent. This does use the new toast service, however.

Add new UseSecurityJobs hook

12a6077

This is incredibly similar to the existing useSiemJobs hook, with the following exceptions: * Does not fetch data if the user is not an ML admin * Returns additional booleans: `isMlAdmin` and `isLicensed` * uses new toasts service

Temporarily relax our helper types

d3e0460

This allows us to use this predicate on both JobSummary and MlSummaryJob until we can consolidate to the former.

Replace remaining uses of useSiemJobs

36d9d4b

This was mostly a dropin replacement for the remaining use cases; there were a few now-unnecessary `isInstalled` filters that were removed.

Delete unused hook

d195945

Rename siemJob -> securityJob

a527d5d

Rename files to be more accurate

9fc91f3

These are helpers for our new hook, not the old one.

Move useMlCapabilities hook to more general folder

bd2c199

This is no longer specific to the ml popover, nor has it been for quite a while.

Fixes type errors

12f27ac

Mocks cleanup

f4781c2

rylnd added release_note:fix Team:SIEM v8.0.0 v7.10.0 labels Aug 6, 2020

rylnd self-assigned this Aug 6, 2020

Merge branch 'master' into fix_unauthed_ml_calls

62b479f

Conflicts: x-pack/plugins/security_solution/common/machine_learning/is_security_job.ts

rylnd force-pushed the fix_unauthed_ml_calls branch from a8d6865 to 62b479f Compare August 6, 2020 19:13

rylnd added 5 commits August 6, 2020 19:25

Add tests for useSecurityJobs hook

66365dc

* moves corresponding API mocks to new .mock format * the automock folder was actually getting in my way * Adds new mocks for our useAppToasts hook

Do not call ML endpoints without valid licensing

f376baa

We have this info here, best to leverage it.

Add tests for useInstalledSecurityJobs hook

404974c

Add helper predicate for checking for a valid license

96f3608

This abstracts away any dealing with our raw capabilities response.

Revert i18n key change

f7aa1fd

There's already a translation for this, no need for extra work here.

rylnd mentioned this pull request Aug 10, 2020

[Security Solution] Anomalies Tables only show data for installed ML Jobs #74697

Closed

Revert to old functionality on rule creation dropdown

be0a06c

For now, we don't want to filter our dropdown to just installed jobs; that's a broader product decision that we'll circle back to.

rylnd force-pushed the fix_unauthed_ml_calls branch from 0459dd6 to be0a06c Compare August 11, 2020 21:29

Replace inline mock with an existing one

7f6aaae

Merge branch 'master' into fix_unauthed_ml_calls

15f26ec

jgowdyelastic approved these changes Aug 12, 2020

View reviewed changes

spong reviewed Aug 12, 2020

View reviewed changes

x-pack/plugins/security_solution/public/common/mock/kibana_core.ts Show resolved Hide resolved

spong approved these changes Aug 13, 2020

View reviewed changes

spong merged commit 4ca52e6 into elastic:master Aug 13, 2020

spong mentioned this pull request Aug 13, 2020

[7.x] [Security Solution][Detections] Refactor ML calls for newest ML permissions (#74582) #74919

Merged

rylnd deleted the fix_unauthed_ml_calls branch August 13, 2020 03:22

rylnd mentioned this pull request Aug 13, 2020

[Security Solution][Detections] Cleaning up mocks/tests #74920

Merged

3 tasks

This was referenced Aug 13, 2020

[Security Solution][Detections] SIEM job fetch failure error toast shown for users without ML permissions #73567

Closed

[7.9] [Security Solution][Detections] Refactor ML calls for newest ML permissions (#74582) #75287

Merged

spong added the v7.9.1 label Aug 18, 2020

rylnd mentioned this pull request Oct 19, 2020

[SIEM] Non-ML users see error toaster on SIEM pages #65602

Closed

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Detections] Refactor ML calls for newest ML permissions #74582

[Security Solution][Detections] Refactor ML calls for newest ML permissions #74582

rylnd commented Aug 6, 2020 •

edited

Loading

rylnd commented Aug 12, 2020

kibanamachine commented Aug 12, 2020

jgowdyelastic left a comment

spong Aug 12, 2020

spong Aug 12, 2020

spong Aug 12, 2020

spong Aug 12, 2020

spong Aug 12, 2020

rylnd Aug 13, 2020

spong Aug 12, 2020 •

edited

Loading

spong Aug 12, 2020

spong left a comment

elasticmachine commented Sep 23, 2021

		const _getJobsSummary = withOptionalSignal(getJobsSummary);

		export const useGetJobsSummary = () => useAsync(_getJobsSummary);

	const [siemDefaultIndex] = useUiSetting$<string[]>(DEFAULT_INDEX_KEY);
	const [securitySolutionDefaultIndex] = useUiSetting$<string[]>(DEFAULT_INDEX_KEY);

	* Representation of an ML Job as used by the SIEM App -- a composition of ModuleJob and MlSummaryJob
	* Representation of an ML Job as used by the Security Solution App -- a composition of ModuleJob and MlSummaryJob

[Security Solution][Detections] Refactor ML calls for newest ML permissions #74582

[Security Solution][Detections] Refactor ML calls for newest ML permissions #74582

Conversation

rylnd commented Aug 6, 2020 • edited Loading

Summary

User has insufficient license

User is ML User

User is ML Admin

Checklist

For maintainers

rylnd commented Aug 12, 2020

kibanamachine commented Aug 12, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

jgowdyelastic left a comment

Choose a reason for hiding this comment

spong Aug 12, 2020

Choose a reason for hiding this comment

spong Aug 12, 2020

Choose a reason for hiding this comment

spong Aug 12, 2020

Choose a reason for hiding this comment

spong Aug 12, 2020

Choose a reason for hiding this comment

spong Aug 12, 2020

Choose a reason for hiding this comment

rylnd Aug 13, 2020

Choose a reason for hiding this comment

spong Aug 12, 2020 • edited Loading

Choose a reason for hiding this comment

spong Aug 12, 2020

Choose a reason for hiding this comment

spong left a comment

Choose a reason for hiding this comment

elasticmachine commented Sep 23, 2021

rylnd commented Aug 6, 2020 •

edited

Loading

spong Aug 12, 2020 •

edited

Loading