[Security Solution][lists] Adds tests for exception lists and items part 2 #74815

FrankHassanabad · 2020-08-12T02:08:38Z

Summary

This is the basics of end to end tests, so there could be a lot more, but this ties to cover the basics of the tests.

Test with:

node scripts/functional_tests --config x-pack/test/lists_api_integration/security_and_spaces/config.ts

Adds these tests for the route counter parts:

create_exception_list_items.ts
create_exception_lists.ts
delete_exception_list_items.ts
delete_exception_lists.ts
find_exception_list_items.ts
find_exception_lists.ts
read_exception_list_items.ts
read_exception_lists.ts
update_exception_list_items.ts
update_exception_lists.ts

Fixes a few minor strings, other tests, but no large bugs found with these tests

Checklist

Unit or functional tests were updated or added to match the most common scenarios

spong · 2020-08-13T02:59:18Z

x-pack/test/lists_api_integration/security_and_spaces/tests/delete_exception_list_items.ts

+        // create an exception list
+        await supertest
+          .post(EXCEPTION_LIST_URL)
+          .set('kbn-xsrf', 'true')
+          .send(getCreateExceptionListMinimalSchemaMock())
+          .expect(200);


These simple blocks get repeated a bit -- 19 for this one. From a readability perspective it may be worth breaking this out as a helper, thoughts? It's nice having the whole block when needing to modify tests, but these seem like pretty simple operations to encapsulate for readability.

Yeah, was debating that. Turning that into a one-liner.

It's boilerplatey and we might with a follow up with doing that here. I won't do it with this one as we have other PR's that are about to go through where we will need these tests in place for some protection against obvious oopsies but down the road I think we should here and probably in detection engine where things repeat.

Appreciate the thoughts.

spong

Checked out, ran tests locally, and code reviewed -- thank you much for filling out these much-needed tests, mocks and helpers here @FrankHassanabad. Feels a lot better going forward with these gaps in coverage filled, and you laid a great foundation to build on as we add features too! LGTM! 👍 🙇‍♂️ 🎉

elasticmachine · 2020-08-13T03:54:48Z

Pinging @elastic/siem (Team:SIEM)

kibanamachine · 2020-08-13T04:28:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e3fc44c

Build metrics

✅ unchanged

History

💚 Build #67647 succeeded 773002e
💚 Build #67634 succeeded 9180ca1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…art 2 (elastic#74815) ## Summary This is the basics of end to end tests, so there could be a lot more, but this ties to cover the basics of the tests. Test with: ```ts node scripts/functional_tests --config x-pack/test/lists_api_integration/security_and_spaces/config.ts ``` Adds these tests for the route counter parts: * create_exception_list_items.ts * create_exception_lists.ts * delete_exception_list_items.ts * delete_exception_lists.ts * find_exception_list_items.ts * find_exception_lists.ts * read_exception_list_items.ts * read_exception_lists.ts * update_exception_list_items.ts * update_exception_lists.ts Fixes a few minor strings, other tests, but no large bugs found with these tests ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

…art 2 (#74815) (#74921) ## Summary This is the basics of end to end tests, so there could be a lot more, but this ties to cover the basics of the tests. Test with: ```ts node scripts/functional_tests --config x-pack/test/lists_api_integration/security_and_spaces/config.ts ``` Adds these tests for the route counter parts: * create_exception_list_items.ts * create_exception_lists.ts * delete_exception_list_items.ts * delete_exception_lists.ts * find_exception_list_items.ts * find_exception_lists.ts * read_exception_list_items.ts * read_exception_lists.ts * update_exception_list_items.ts * update_exception_lists.ts Fixes a few minor strings, other tests, but no large bugs found with these tests ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

* master: (28 commits) [Task manager] Prevents edge case where already running tasks are reschedule every polling interval (elastic#74606) [Security Solution] Fix the status of timelines' bulk actions (elastic#74560) Data plugin: Suggested enhance pattern (elastic#74505) Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (elastic#74642) [Security Solution][lists] Adds tests for exception lists and items part 2 (elastic#74815) [Security Solution][Resolver] fix presentation role on edgeline (elastic#74869) [Security Solution][Detections] Refactor ML calls for newest ML permissions (elastic#74582) [bin/kibana-plugin] support KP plugins instead (elastic#74604) Reduce number of indexed fields in index pattern saved object (elastic#74817) [reporting] Pass along generic parameters in high-order route handler (elastic#74892) Migrated last pieces of legacy fixture code (elastic#74470) Empty index patterns page re-design (elastic#68819) [babel] coalese some versions to prevent breaking yarn install (elastic#74864) [Dashboard First] Decouple Attribute Service and By Value Embeddables (elastic#74302) Revert "[reporting] Pass along generic parameters in high-order route handler" (elastic#74891) [reporting] Pass along generic parameters in high-order route handler (elastic#74879) [src/dev/build] implement a getBuildNumber() mock (elastic#74881) [Enterprise Search] Add solution-level side navigation (elastic#74705) [DOCS] Canvas docs 7.9 refresh (elastic#74000) [Security Solution][Resolver]Enzyme test related events closing (elastic#74811) ...

…le-buffer-with-update-of-same-id * upstream/master: (37 commits) [Task manager] Prevents edge case where already running tasks are reschedule every polling interval (elastic#74606) [Security Solution] Fix the status of timelines' bulk actions (elastic#74560) Data plugin: Suggested enhance pattern (elastic#74505) Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (elastic#74642) [Security Solution][lists] Adds tests for exception lists and items part 2 (elastic#74815) [Security Solution][Resolver] fix presentation role on edgeline (elastic#74869) [Security Solution][Detections] Refactor ML calls for newest ML permissions (elastic#74582) [bin/kibana-plugin] support KP plugins instead (elastic#74604) Reduce number of indexed fields in index pattern saved object (elastic#74817) [reporting] Pass along generic parameters in high-order route handler (elastic#74892) Migrated last pieces of legacy fixture code (elastic#74470) Empty index patterns page re-design (elastic#68819) [babel] coalese some versions to prevent breaking yarn install (elastic#74864) [Dashboard First] Decouple Attribute Service and By Value Embeddables (elastic#74302) Revert "[reporting] Pass along generic parameters in high-order route handler" (elastic#74891) [reporting] Pass along generic parameters in high-order route handler (elastic#74879) [src/dev/build] implement a getBuildNumber() mock (elastic#74881) [Enterprise Search] Add solution-level side navigation (elastic#74705) [DOCS] Canvas docs 7.9 refresh (elastic#74000) [Security Solution][Resolver]Enzyme test related events closing (elastic#74811) ...

* upstream/master: (45 commits) [Metrics UI] Fix inventory footer misalignment (elastic#74707) Remove legacy optimizer (elastic#73154) Update design-specific GH code-owners (elastic#74877) skip test Reporting paginates content elastic#74922 [Metrics UI] Add Jest tests for alert previews (elastic#74890) Fixed tooltip (elastic#74074) [Ingest Pipelines] Processor forms for processors A-D (elastic#72849) [Observability] change ingest manager link (elastic#74928) [Task manager] Prevents edge case where already running tasks are reschedule every polling interval (elastic#74606) [Security Solution] Fix the status of timelines' bulk actions (elastic#74560) Data plugin: Suggested enhance pattern (elastic#74505) Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (elastic#74642) [Security Solution][lists] Adds tests for exception lists and items part 2 (elastic#74815) [Security Solution][Resolver] fix presentation role on edgeline (elastic#74869) [Security Solution][Detections] Refactor ML calls for newest ML permissions (elastic#74582) [bin/kibana-plugin] support KP plugins instead (elastic#74604) Reduce number of indexed fields in index pattern saved object (elastic#74817) [reporting] Pass along generic parameters in high-order route handler (elastic#74892) Migrated last pieces of legacy fixture code (elastic#74470) Empty index patterns page re-design (elastic#68819) ...

elasticmachine · 2021-09-23T14:27:00Z

Pinging @elastic/security-solution (Team: SecuritySolution)

FrankHassanabad added 5 commits August 11, 2020 20:07

Added tests for exception lists and fixed one flaky test found

9180ca1

Added more unit tests for the exception_list_items

773002e

Merge branch 'master' into add-list-end-to-end-part-2

30e39a2

Added other end to end tests to complete the exception list items

3841ab3

Merge branch 'master' into add-list-end-to-end-part-2

e3fc44c

FrankHassanabad changed the title ~~[Security Solution][lists] Adds tests for exception lists and fixes one flaky test~~ [Security Solution][lists] Adds tests for exception lists and items part 2 Aug 13, 2020

FrankHassanabad self-assigned this Aug 13, 2020

FrankHassanabad added release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.9.0 v8.0.0 and removed v7.9.0 labels Aug 13, 2020

FrankHassanabad marked this pull request as ready for review August 13, 2020 02:39

FrankHassanabad requested review from a team as code owners August 13, 2020 02:39

spong reviewed Aug 13, 2020

View reviewed changes

spong approved these changes Aug 13, 2020

View reviewed changes

FrankHassanabad added the Team:SIEM label Aug 13, 2020

FrankHassanabad merged commit db357a2 into elastic:master Aug 13, 2020

FrankHassanabad deleted the add-list-end-to-end-part-2 branch August 13, 2020 04:32

FrankHassanabad mentioned this pull request Aug 13, 2020

[7.x] [Security Solution][lists] Adds tests for exception lists and items part 2 (#74815) #74921

Merged

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][lists] Adds tests for exception lists and items part 2 #74815

[Security Solution][lists] Adds tests for exception lists and items part 2 #74815

FrankHassanabad commented Aug 12, 2020 •

edited

Loading

spong Aug 13, 2020

FrankHassanabad Aug 13, 2020

spong left a comment

elasticmachine commented Aug 13, 2020

kibanamachine commented Aug 13, 2020

elasticmachine commented Sep 23, 2021

[Security Solution][lists] Adds tests for exception lists and items part 2 #74815

[Security Solution][lists] Adds tests for exception lists and items part 2 #74815

Conversation

FrankHassanabad commented Aug 12, 2020 • edited Loading

Summary

Checklist

spong Aug 13, 2020

Choose a reason for hiding this comment

FrankHassanabad Aug 13, 2020

Choose a reason for hiding this comment

spong left a comment

Choose a reason for hiding this comment

elasticmachine commented Aug 13, 2020

kibanamachine commented Aug 13, 2020

💚 Build Succeeded

Build metrics

History

elasticmachine commented Sep 23, 2021

FrankHassanabad commented Aug 12, 2020 •

edited

Loading