Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functional]Table Vis increase sleep time in order filter to be applied #75138

Merged
merged 3 commits into from
Aug 19, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Aug 17, 2020

Summary

Closes #74434.
This test fails because it fetches the data before the filter manages to be applied. It doesn't fail often and I couldn't replicate it but I want to try to give more time to sleep to check if it is going to solve the problem.
https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/93/

Checklist

Delete any items that are not applicable to this PR.

@stratoula stratoula marked this pull request as ready for review August 18, 2020 06:39
@stratoula stratoula added v7.10.0 Feature:Functional Testing Feature:Data Table Data table visualization feature v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Aug 18, 2020
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I know you just want to check if more time helps this, but it is best to replace sleeps with something event driven.

@stratoula
Copy link
Contributor Author

@liza-mae if it fails again then I will have to do a refactor as it is kind of tricky. So let's try this super simple solution and then proceed with something else

@stratoula stratoula merged commit 9a22ef2 into elastic:master Aug 19, 2020
stratoula added a commit to stratoula/kibana that referenced this pull request Aug 19, 2020
…ed (elastic#75138)

* Increase sleep time in order filter to be applied

* revert

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 19, 2020
* master: (30 commits)
  [code coverage] always download node before team assignment (elastic#75424)
  [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302)
  [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555)
  skip flaky suite (elastic#75440)
  skip flaky suite (elastic#75386)
  [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172)
  [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138)
  MOAR RAM (elastic#75423)
  [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315)
  [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499)
  [ML] Inference models management (elastic#74978)
  [Monitoring] Migrate karma tests (elastic#75301)
  [Index template] Add filters to simulate preview (elastic#74497)
  Bump and consolidate dependencies (elastic#75360)
  [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364)
  Update Node.js to version 10.22.0 (elastic#75254)
  [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953)
  [Discover] Fix histogram cloud tests (elastic#75268)
  Uiactions to navigate to visualize or maps (elastic#74121)
  Use prefix search invis editor field/agg combo box (elastic#75290)
  ...
stratoula added a commit that referenced this pull request Aug 20, 2020
…ed (#75138) (#75445)

* Increase sleep time in order filter to be applied

* revert

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Table Data table visualization feature Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
4 participants