Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump and consolidate dependencies #75360

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

jportner
Copy link
Contributor

This commit bumps and consolidates several transitive dependencies:

  • ajv 6.12.2
  • har-validator 5.1.3
  • request 2.88.2
  • schema-utils 1.0.0

Note: an older version of ajv and schema-utils are each still present because they are included in dev dependencies. I opted not to attempt to update these.

This commit bumps and consolidates several transitive dependencies:
* ajv `6.12.2`
* har-validator `5.1.3`
* request `2.88.2`
* schema-utils `1.0.0`

Note: an older version of ajv and schema-utils are each still
present because they are included in dev dependencies. I opted not
to attempt to update these.
Copy link
Contributor Author

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Author's notes for reviewers.

@@ -90,11 +90,13 @@
"**/graphql-toolkit/lodash": "^4.17.15",
"**/hoist-non-react-statics": "^3.3.2",
"**/isomorphic-git/**/base64-js": "^1.2.1",
"**/istanbul-instrumenter-loader/schema-utils": "1.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This selective dependency resolution forces schema-utils 0.3.0 to resolve to 1.0.0. According to the changelog, there are no breaking changes between these versions.

"**/image-diff/gm/debug": "^2.6.9",
"**/load-grunt-config/lodash": "^4.17.20",
"**/react-dom": "^16.12.0",
"**/react": "^16.12.0",
"**/react-test-renderer": "^16.12.0",
"**/request": "^2.88.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This selective dependency resolution forces several different versions of request (all between 2.74.0 and 2.88.2) to resolve to 2.88.2. According to the changelog, there are no breaking changes between these versions.

@jportner jportner added the release_note:skip Skip the PR/issue when compiling release notes label Aug 18, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
enterpriseSearch 359.2KB +78.0B 359.1KB

page load bundle size

id value diff baseline
upgradeAssistant 64.7KB +78.0B 64.6KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner marked this pull request as ready for review August 18, 2020 22:11
@jportner jportner requested a review from a team August 18, 2020 22:13
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jportner jportner merged commit 87414ad into elastic:master Aug 19, 2020
@jportner jportner deleted the bump-and-consolidate-dependencies branch August 19, 2020 13:54
jportner added a commit to jportner/kibana that referenced this pull request Aug 19, 2020
jportner added a commit to jportner/kibana that referenced this pull request Aug 19, 2020
jportner added a commit to jportner/kibana that referenced this pull request Aug 19, 2020
# Conflicts:
#	package.json
#	yarn.lock
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 19, 2020
* master: (30 commits)
  [code coverage] always download node before team assignment (elastic#75424)
  [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302)
  [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555)
  skip flaky suite (elastic#75440)
  skip flaky suite (elastic#75386)
  [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172)
  [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138)
  MOAR RAM (elastic#75423)
  [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315)
  [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499)
  [ML] Inference models management (elastic#74978)
  [Monitoring] Migrate karma tests (elastic#75301)
  [Index template] Add filters to simulate preview (elastic#74497)
  Bump and consolidate dependencies (elastic#75360)
  [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364)
  Update Node.js to version 10.22.0 (elastic#75254)
  [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953)
  [Discover] Fix histogram cloud tests (elastic#75268)
  Uiactions to navigate to visualize or maps (elastic#74121)
  Use prefix search invis editor field/agg combo box (elastic#75290)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants