Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Account for "properties" layer in find_file_structure mappings #77035

Merged
merged 2 commits into from
Sep 9, 2020
Merged

[ML] Account for "properties" layer in find_file_structure mappings #77035

merged 2 commits into from
Sep 9, 2020

Commits on Sep 9, 2020

  1. [ML] Account for "properties" layer in find_file_structure mappings 

    This is the UI side companion for elastic/elasticsearch#62158

Previously the "mappings" field of the response from the
find_file_structure endpoint was not a drop-in for the
mappings format of the create index endpoint - the
"properties" layer was missing. The reason for omitting
it initially was that the assumption was that the
find_file_structure endpoint would only ever return very
simple mappings without any nested objects. However,
this will not be true in the future, as we will improve
mappings detection for complex JSON objects. As a first
step it makes sense to move the returned mappings closer
to the standard format.
    @droberts195
    droberts195 committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    056a67f View commit details
    Browse the repository at this point in the history

  2. Addressing code review comments

    @droberts195
    droberts195 committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    c1af6e2 View commit details
    Browse the repository at this point in the history