Move remaining uses of serviceName away from urlParams #77248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few of these that were either missed or lost in merge conflict resolution. I went through everything that's used as a path parameter and made sure it wasn't being used anywhere with `urlParams`. Previously none of the charts were working, now they all are.
smith
added
v8.0.0
release_note:skip
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Sep 14, 2020
sorenlouv
reviewed
Sep 14, 2020
| @@ -20,10 +20,11 @@ const CoreVitalsThresholds = { | |||
| export function CoreVitals() { | |||
| const { urlParams, uiFilters } = useUrlParams(); | |||
There was a problem hiding this comment.
Should we rename this to make the distinction between path params (that we get from react-router) and query params clear?
Suggested change
| const { urlParams, uiFilters } = useUrlParams(); | |
| const { queryParams, uiFilters } = useQueryParams(); |
There was a problem hiding this comment.
I'd be fine with doing that but we would have to change it in a hell of a lot of places. I'd prefer doing that change in the next round of changes and leaving it for now.
|
@elasticmachine merge upstream |
smith
commented
Sep 14, 2020
| @@ -7,10 +7,9 @@ | |||
| import { EuiSuperDatePicker } from '@elastic/eui'; | |||
| import { isEmpty, isEqual, pickBy } from 'lodash'; | |||
| import React from 'react'; | |||
| import { useHistory } from 'react-router-dom'; | |||
| import { useHistory, useLocation } from 'react-router-dom'; | |||
There was a problem hiding this comment.
Replacing our useLocation here with the one from react-router-dom. This is also fixed in #76343 but CSM is not using our old location provider.
|
retest |
Looks like elastic#67791 introduced a find/replace change that broke APM's e2e tests. This reverts that change.
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
Closed
smith
added a commit
to smith/kibana
that referenced
this pull request
Sep 15, 2020
* Move remaining uses of serviceName away from urlParams There were a few of these that were either missed or lost in merge conflict resolution. I went through everything that's used as a path parameter and made sure it wasn't being used anywhere with `urlParams`. Previously none of the charts were working, now they all are. Looks like elastic#67791 introduced a find/replace change that broke APM's e2e tests. This reverts that change.
smith
added a commit
that referenced
this pull request
Sep 15, 2020
* Move remaining uses of serviceName away from urlParams There were a few of these that were either missed or lost in merge conflict resolution. I went through everything that's used as a path parameter and made sure it wasn't being used anywhere with `urlParams`. Previously none of the charts were working, now they all are. Looks like #67791 introduced a find/replace change that broke APM's e2e tests. This reverts that change.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 15, 2020
* master: (25 commits) [Security Solution] Add unit tests for Network search strategy (elastic#77416) [Alerting] Improves performance of the authorization filter in AlertsClient.find by skipping KQL parsing (elastic#77040) [Ingest Manager] Add route for package installation by upload (elastic#77044) [APM-UI][E2E] filter PRs from the uptime GH team (elastic#77359) [APM] Remove useLocation and some minor route improvements (elastic#76343) [Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper (elastic#77258) [SECURITY_SOLUTION] Task/hostname policy response ux updates (elastic#76444) Move remaining uses of serviceName away from urlParams (elastic#77248) [Lens] Move configuration popover to flyout (elastic#76046) [Ingest Manager] Manually build Fleet kuery with Node arguments (elastic#76589) skip flaky suite (elastic#59975) Neutral-naming in reporting plugin (elastic#77371) [Enterprise Search] Add UserIcon styles (elastic#77385) [RUM Dashboard] Added loading state to visitor breakdown pie charts (elastic#77201) [Ingest Manager] Fix polling for new agent action (elastic#77339) Remote cluster - Functional UI test to change the superuser to a test_user with limited role (elastic#77212) Stacked headers and navigational search (elastic#72331) [ML] DF Analytics creation wizard: Fixing field loading race condition (elastic#77326) [Monitoring] Handle no mappings found for sort and collapse fields (elastic#77099) Add Lens to Recently Accessed (elastic#77249) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 15, 2020
* master: (293 commits) Fix tsvb filter ration for table (elastic#77272) [Security Solution] Add unit tests for Network search strategy (elastic#77416) [Alerting] Improves performance of the authorization filter in AlertsClient.find by skipping KQL parsing (elastic#77040) [Ingest Manager] Add route for package installation by upload (elastic#77044) [APM-UI][E2E] filter PRs from the uptime GH team (elastic#77359) [APM] Remove useLocation and some minor route improvements (elastic#76343) [Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper (elastic#77258) [SECURITY_SOLUTION] Task/hostname policy response ux updates (elastic#76444) Move remaining uses of serviceName away from urlParams (elastic#77248) [Lens] Move configuration popover to flyout (elastic#76046) [Ingest Manager] Manually build Fleet kuery with Node arguments (elastic#76589) skip flaky suite (elastic#59975) Neutral-naming in reporting plugin (elastic#77371) [Enterprise Search] Add UserIcon styles (elastic#77385) [RUM Dashboard] Added loading state to visitor breakdown pie charts (elastic#77201) [Ingest Manager] Fix polling for new agent action (elastic#77339) Remote cluster - Functional UI test to change the superuser to a test_user with limited role (elastic#77212) Stacked headers and navigational search (elastic#72331) [ML] DF Analytics creation wizard: Fixing field loading race condition (elastic#77326) [Monitoring] Handle no mappings found for sort and collapse fields (elastic#77099) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few of these that were either missed or lost in merge conflict resolution.
I went through everything that's used as a path parameter and made sure it wasn't being used anywhere with
urlParams.Previously none of the charts were working, now they all are.