Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lens to Recently Accessed #77249

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Sep 10, 2020

Summary

A quick implementation to place Lens visualizations in the recently accessed section.

This PR adds to the recently accessed from app.tsx instead of through the savedObjectStore so that embeddables won't cause an addition.

Note that because of: #64629 accessing these links may cause a full page reload.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson changed the title added lens to recently accessed on load and save in app.tsx Add Lens to Recently Accessed Sep 10, 2020
@ThomThomson ThomThomson marked this pull request as ready for review September 14, 2020 14:03
@ThomThomson ThomThomson requested a review from a team September 14, 2020 14:03
@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Firefox and works as expected, LGTM. Left a small nit but it's not very important

Currently, this triggers a full page reload if you aren't already within the Lens app and loses the time range and pinned filters while doing so. This is documented in #64629

@@ -16,3 +16,7 @@ export function getBasePath() {
export function getEditPath(id: string) {
return `#/edit/${encodeURIComponent(id)}`;
}

export function getFullPath(id: string) {
return `/app/${PLUGIN_ID}#/edit/${encodeURIComponent(id)}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This could call getEditPath instead of inlining the logic

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
lens 26.0KB +168.0B 25.9KB

page load bundle size

id value diff baseline
lens 1.0MB +505.0B 1.0MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 003fcb1 into elastic:master Sep 14, 2020
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Sep 14, 2020
added lens to recently accessed on load and save in app.tsx
ThomThomson added a commit that referenced this pull request Sep 14, 2020
added lens to recently accessed on load and save in app.tsx
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 15, 2020
* master: (25 commits)
  [Security Solution] Add unit tests for Network search strategy (elastic#77416)
  [Alerting] Improves performance of the authorization filter in AlertsClient.find by skipping KQL parsing (elastic#77040)
  [Ingest Manager] Add route for package installation by upload (elastic#77044)
  [APM-UI][E2E] filter PRs from the uptime GH team (elastic#77359)
  [APM] Remove useLocation and some minor route improvements (elastic#76343)
  [Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper (elastic#77258)
  [SECURITY_SOLUTION] Task/hostname policy response ux updates (elastic#76444)
  Move remaining uses of serviceName away from urlParams (elastic#77248)
  [Lens] Move configuration popover to flyout (elastic#76046)
  [Ingest Manager] Manually build Fleet kuery with Node arguments (elastic#76589)
  skip flaky suite (elastic#59975)
  Neutral-naming in reporting plugin (elastic#77371)
  [Enterprise Search] Add UserIcon styles (elastic#77385)
  [RUM Dashboard] Added loading state to visitor breakdown pie charts (elastic#77201)
  [Ingest Manager] Fix polling for new agent action (elastic#77339)
  Remote cluster - Functional UI test to change the superuser to a test_user with limited role (elastic#77212)
  Stacked headers and navigational search (elastic#72331)
  [ML] DF Analytics creation wizard: Fixing field loading race condition (elastic#77326)
  [Monitoring] Handle no mappings found for sort and collapse fields (elastic#77099)
  Add Lens to Recently Accessed (elastic#77249)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants