[ML] File data viz fix fields from mappings #77251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
:ml
bug
|
Pinging @elastic/ml-ui (:ml) |
|
@elasticmachine merge upstream |
pheyos
reviewed
Sep 15, 2020
| async assertNumberOfFieldCards(number: number) { | ||
| const cards = await testSubjects.findAll('mlPageFileDataVisFieldDataCard'); | ||
| if (cards.length !== number) { | ||
| throw new Error(`expected ${number} field cards to exist, but found ${cards.length}`); |
There was a problem hiding this comment.
While this works, I'd suggest to use expect which is used for most of our assertions, something like
expect(cards.length).to.eql(number, `expected ${number} field cards to exist, but found ${cards.length}`);
There was a problem hiding this comment.
changed in 088c544
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Sep 15, 2020
* [ML] File data viz fix fields from mappings * adding card count test * updating test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jgowdyelastic
added a commit
that referenced
this pull request
Sep 15, 2020
* [ML] File data viz fix fields from mappings * adding card count test * updating test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
propertiesas a field in the UI which was introduced by accident as part of the changes in elastic/elasticsearch#62158 and #77035Fixes #77220