Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Stacked headers and navigational search (#72331) #77407

Merged
merged 4 commits into from
Sep 15, 2020
Merged

[7.x] Stacked headers and navigational search (#72331) #77407

merged 4 commits into from
Sep 15, 2020

Conversation

myasonik
Copy link
Contributor

Backports the following commits to 7.x:

Stacked headers and navigational search (elastic#72331)
00d5895 
Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>
# Conflicts:
#	.github/CODEOWNERS
#	src/plugins/dashboard/public/plugin.tsx
#	src/plugins/discover/public/plugin.ts
#	src/plugins/visualize/public/plugin.ts
@myasonik
Copy link
Contributor Author

retest

@myasonik
Copy link
Contributor Author

@elasticmachine merge upstream

@myasonik
Copy link
Contributor Author

@elasticmachine merge upstream

@myasonik
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
core 558 -1 559
globalSearchBar 13 +13 -
kibanaReact 296 +1 295
painlessLab 43 -1 44
total +12

async chunks size

id value diff baseline
advancedSettings 63.8KB -2.2KB 65.9KB
canvas 1.4MB -467.0B 1.4MB
discover 431.2KB +106.0B 431.1KB
graph 1.4MB +87.0B 1.4MB
ingestManager 1.1MB -2.4KB 1.1MB
lens 26.2KB +130.0B 26.0KB
maps 3.3MB +331.0B 3.3MB
painlessLab 182.0KB -2.4KB 184.4KB
timelion 598.4KB -140.0B 598.5KB
visualize 697.8KB +129.0B 697.7KB
total -6.8KB

page load bundle size

id value diff baseline
apm 42.3KB +43.0B 42.2KB
canvas 1.3MB +45.0B 1.3MB
console 30.3KB -124.0B 30.4KB
core 1.2MB -7.0KB 1.2MB
dashboard 712.0KB +375.0B 711.6KB
devTools 166.1KB -128.0B 166.2KB
discover 229.9KB +591.0B 229.3KB
enterpriseSearch 22.5KB +87.0B 22.4KB
globalSearchBar 28.8KB +28.8KB -
graph 15.8KB +2.0B 15.8KB
infra 277.4KB +17.0B 277.3KB
ingestManager 468.5KB -4.0B 468.5KB
kibanaLegacy 232.6KB +47.0B 232.5KB
kibanaReact 648.7KB +480.0B 648.2KB
management 30.1KB -2.0B 30.1KB
maps 301.1KB +146.0B 300.9KB
ml 845.3KB +47.0B 845.3KB
navigation 164.7KB -860.0B 165.5KB
observability 51.8KB +32.0B 51.7KB
painlessLab 161.0KB +4.0B 161.0KB
searchprofiler 50.8KB -136.0B 50.9KB
securitySolution 793.0KB +46.0B 793.0KB
timelion 14.4KB -1.0B 14.4KB
uptime 25.1KB +8.0B 25.1KB
visualize 41.2KB +94.0B 41.1KB
total +22.7KB

distributable file count

id value diff baseline
default 47245 +4 47241

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@myasonik myasonik merged commit 1868e6b into elastic:7.x Sep 15, 2020
@myasonik myasonik deleted the backport/7.x/pr-72331 branch September 15, 2020 16:37
@tylersmalley
Copy link
Contributor

Forgot to remove the CODEOWNERES file - I remove it from the 7.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@myasonik @kibanamachine @tylersmalley @elasticmachine