Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Different field format on different series is ignored #78138

Merged
merged 7 commits into from
Sep 29, 2020
Merged

[TSVB] Different field format on different series is ignored #78138

merged 7 commits into from
Sep 29, 2020

Conversation

DianaDerevyankina
Copy link
Contributor

@DianaDerevyankina DianaDerevyankina commented Sep 22, 2020 •
edited by stratoula
Loading

Closes #74951
Closes #78426

  1. To fix incorrect tooltip and legend displaying added tickFormatter through decorators to each series settings instead of setting the only one for axis.
  2. To change the Y-axis captions its formatter now returns a simple value instead of first series formatter.

image

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@DianaDerevyankina DianaDerevyankina added Feature:TSVB TSVB (Time Series Visual Builder) v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Sep 22, 2020
@DianaDerevyankina DianaDerevyankina self-assigned this Sep 22, 2020
sulemanof
sulemanof approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Tested locally in Chrome, works as expected

@sulemanof sulemanof marked this pull request as ready for review September 23, 2020 12:59
@sulemanof sulemanof requested a review from a team September 23, 2020 12:59
@DianaDerevyankina DianaDerevyankina added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 23, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

nickofthyme
nickofthyme approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Code changes LGTM.

@nickofthyme
Copy link
Contributor

nickofthyme commented Sep 23, 2020 •
edited
Loading

One thing to note is that when no axis.tickFormat is provided it will use the first series.tickFormat. In this case we may want to add a generic axis tick formatter with just the value.

Image 2020-09-23 at 11 48 24 AM

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

stratoula
stratoula approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome. LGTM 🎉

@stratoula
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@DianaDerevyankina DianaDerevyankina merged commit 6f2fd54 into elastic:master Sep 29, 2020
@DianaDerevyankina DianaDerevyankina mentioned this pull request Sep 29, 2020
Merged
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this pull request Sep 29, 2020
@DianaDerevyankina @elasticmachine
[TSVB] Different field format on different series is ignored (elastic…
b26bc02 
…#78138)

* [TSVB] Different field format on different series is ignored

Closes elastic#74951

* Replace formatter of Y axis with simple value instead of formatter of the first series

* Add a condition to Y-axis tickFormatter to display formatted value if there's only one series

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 29, 2020
@gmmorris
Merge branch 'master' into actions/test-connector
4943c44 
* master: (365 commits)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  [Security Solution] Fixes url timeline flaky test (elastic#78556)
  adds retryability feature (elastic#78611)
  Aligns several module versions across the repository (elastic#78327)
  Empty prompt and loading spinner for service map (elastic#78382)
  Change progress bar to spinner (elastic#78460)
  [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111)
  Slim down core bundle (elastic#75912)
  [Alerting] retry internal OCC calls within alertsClient (elastic#77838)
  [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656)
  [Ingest Manager] Ingest setup upgrade (elastic#78081)
  [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520)
  fix name without a category or if field end with .text (elastic#78655)
  [Security Solution] [Detections] Log message enhancements (elastic#78429)
  [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303)
  ...
DianaDerevyankina added a commit that referenced this pull request Sep 29, 2020
@DianaDerevyankina @elasticmachine
[TSVB] Different field format on different series is ignored (#78138) (…
282a1d6 
…#78730)

* [TSVB] Different field format on different series is ignored

Closes #74951

* Replace formatter of Y axis with simple value instead of formatter of the first series

* Add a condition to Y-axis tickFormatter to display formatted value if there's only one series

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
phillipb added a commit to phillipb/kibana that referenced this pull request Sep 29, 2020
@phillipb
Merge branch 'master' of github.com:elastic/kibana into add-anomalies…
f7e5f99 
…-to-timeline

* 'master' of github.com:elastic/kibana: (22 commits)
  update apm index pattern (elastic#78732)
  78024: move transform out of dataset (elastic#78216)
  [QA][Code Coverage] Upload the coverage static site before ingestion (elastic#78695)
  [Discover] Make _source field not clickable (elastic#78698)
  [Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (elastic#78685)
  [APM] Review feedback from distribution + transaction metrics (elastic#78752)
  [Ingest pipelines] Add ability to stop pipeline simulation  (elastic#78183)
  [CSM] Fix core vital legend background (elastic#78273)
  [Usage Collection] [schema] Support spreads + `canvas` definition (elastic#78481)
  fix lodash imports (elastic#78456)
  [Maps] Add layer type preview icons (elastic#78650)
  [APM] Use transaction metrics for distribution charts (elastic#78484)
  [Uptime] Ml anomaly alert edit (elastic#76909)
  [ML] Limit exposing shared static code through ml/public/index.ts. (elastic#77745)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulemanof sulemanof sulemanof approved these changes

@alexwizp alexwizp alexwizp approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

@DianaDerevyankina DianaDerevyankina

Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
7 participants
@DianaDerevyankina @elasticmachine @nickofthyme @stratoula @kibanamachine @alexwizp @sulemanof