[Ingest pipelines] Add ability to stop pipeline simulation #78183

alisonelizabeth · 2020-09-22T17:25:20Z

This PR adds the ability to stop/reset testing a pipeline.

This addresses feedback received here: #74964 (review).

How to test

Create a pipeline and add some sample documents (for a sample pipeline and documents, see: [Ingest pipelines] Test pipeline enhancements #74964).
Click the documents dropdown, and click the "Reset" link.
Verify modal opens
After confirming, verify the sample documents added in step 1 no longer exist, and the status of each processor is reset to "Not run".

Screenshots

elasticmachine · 2020-09-22T17:52:41Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

jloleysens

Great work @alisonelizabeth ! I think this is a nice UX polish! I looked at the code and everything looks good to me, thanks for adding tests too!

I looked at the current UI and I have some suggestions about what I think would be cool, but not necessarily work that needs to be done in this PR.

To my mind the "edit documents" and "reset" buttons represent actions that both are scoped to documents, so it makes sense they live together as they currently do. An improvement on this, I think, is moving them out of the document selector dropdown -- so that the selector is just a selector (second image).

The controls for selecting and managing documents can be grouped visually (per image 1, not showing view output as I think this is distinct from managing documents). These controls could live in a bottom bar because they are not "primary" level actions to editing the pipeline but relevant to the process of testing.

Image 1

Image 2

I think it would be great to hear from @mdefazio or others on this too.

jloleysens · 2020-09-23T10:52:04Z

...ion/components/pipeline_processors_editor/components/test_pipeline/test_pipeline_actions.tsx

@@ -49,6 +49,12 @@ export const TestPipelineActions: FunctionComponent = () => {
 });
 };

+ const stopPipelineSimulation = () => {
+ setCurrentTestPipelineData({


nit; I think a better name for setCurrentTestPipelineData would be testPipelineDataDispatch (if we want to disambiguate) otherwise dispatch.

mdefazio · 2020-09-24T01:29:05Z

One thought I had on this was instead of 'Reset', this is a toggle button that says 'Autorun test' and then 'Test paused'. (Probably better text here). Then reseting the documents can be done in the document flyout only.

…nes/reset_test

alisonelizabeth · 2020-09-28T16:04:37Z

One thought I had on this was instead of 'Reset', this is a toggle button that says 'Autorun test' and then 'Test paused'. (Probably better text here). Then reseting the documents can be done in the document flyout only.

@mdefazio Thanks for the suggestions! Would you mind taking another look when you get a chance?

Based on your feedback on #77939, I've added a "Clear all" button to the flyout and removed the "Reset" button originally added in this PR. The "paused" toggle is an interesting idea. I think it needs to be fleshed out a little more. For example, if it was "paused", would the documents in the dropdown list be disabled? Also, would you still be able to click the "View output" button?

I think adding the "Clear all" button resolves the original concern about being stuck in testing mode and is a good step forward. I think I'd prefer to hold off on the toggle for now, unless you feel strongly about it.

Latest screenshots:

mdefazio

This all looks good. I have one tiny nit: Can we update the Edit documents button so it uses the EuiPopoverFooter (and add the fullWidth prop? Might simplify things a bit but also want to make sure the button spans the width of the popover.

The toggle isn't really necessary anymore IMO.

alisonelizabeth · 2020-09-29T01:22:34Z

Thanks @mdefazio! I was not aware of the EuiPopoverFooter. That does simplify things a bit! Mind taking one last look when you get a chance?

kibanamachine · 2020-09-29T02:53:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2b5bb3b

Metrics [docs]

@kbn/optimizer bundle module count

id	value	diff	baseline
ingestPipelines	493	+10	483

async chunks size

id	value	diff	baseline
ingestPipelines	814.4KB	+5.7KB	808.7KB

History

💚 Build #77518 succeeded f5205b8
💚 Build #77474 succeeded 39c7d79
💚 Build #76261 succeeded 743c915

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mdefazio

Looks good! Thanks for making that edit.

…8183)

…78766)

…-to-timeline * 'master' of github.com:elastic/kibana: (22 commits) update apm index pattern (elastic#78732) 78024: move transform out of dataset (elastic#78216) [QA][Code Coverage] Upload the coverage static site before ingestion (elastic#78695) [Discover] Make _source field not clickable (elastic#78698) [Fleet] Rename Ingest Manager => Fleet, Fleet => Agents in the UI (elastic#78685) [APM] Review feedback from distribution + transaction metrics (elastic#78752) [Ingest pipelines] Add ability to stop pipeline simulation (elastic#78183) [CSM] Fix core vital legend background (elastic#78273) [Usage Collection] [schema] Support spreads + `canvas` definition (elastic#78481) fix lodash imports (elastic#78456) [Maps] Add layer type preview icons (elastic#78650) [APM] Use transaction metrics for distribution charts (elastic#78484) [Uptime] Ml anomaly alert edit (elastic#76909) [ML] Limit exposing shared static code through ml/public/index.ts. (elastic#77745) making expression debug info serializable (elastic#78727) fix lodahs imports in app-arch code (elastic#78582) Make Field a React.lazy export (elastic#78483) [Security Solution] Improves detections tests (elastic#77295) [TSVB] Different field format on different series is ignored (elastic#78138) RFC: Improve saved object migrations (elastic#66056) ...

alisonelizabeth added 2 commits September 22, 2020 10:56

add ability to stop pipeline simulation

e6b888c

add tests

743c915

alisonelizabeth added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Feature:Ingest Node Pipelines Ingest node pipelines management labels Sep 22, 2020

alisonelizabeth marked this pull request as ready for review September 22, 2020 17:52

alisonelizabeth requested a review from a team as a code owner September 22, 2020 17:52

alisonelizabeth requested a review from jloleysens September 22, 2020 17:52

jloleysens approved these changes Sep 23, 2020

View reviewed changes

alisonelizabeth mentioned this pull request Sep 24, 2020

[Ingest pipelines] Upload indexed document to test a pipeline #77939

Merged

alisonelizabeth added 3 commits September 24, 2020 13:33

Merge branch 'master' of github.com:elastic/kibana into ingest_pipeli…

e8c533b

…nes/reset_test

Merge branch 'master' of github.com:elastic/kibana into ingest_pipeli…

87ab6db

…nes/reset_test

move reset functionality to flyout

39c7d79

alisonelizabeth requested a review from a team as a code owner September 28, 2020 15:15

address review feedback

f5205b8

alisonelizabeth requested a review from mdefazio September 28, 2020 15:52

mdefazio requested changes Sep 28, 2020

View reviewed changes

address design feedback

2b5bb3b

mdefazio approved these changes Sep 29, 2020

View reviewed changes

alisonelizabeth merged commit 6f33012 into elastic:master Sep 29, 2020

alisonelizabeth deleted the ingest_pipelines/reset_test branch September 29, 2020 13:29

alisonelizabeth mentioned this pull request Sep 29, 2020

[7.x] [Ingest pipelines] Add ability to stop pipeline simulation (#78183) #78766

Merged

alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Sep 29, 2020

[Ingest pipelines] Add ability to stop pipeline simulation (elastic#7…

b25fdcf

…8183)

alisonelizabeth added a commit that referenced this pull request Sep 29, 2020

[Ingest pipelines] Add ability to stop pipeline simulation (#78183) (#…

56f032e

…78766)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ingest pipelines] Add ability to stop pipeline simulation #78183

[Ingest pipelines] Add ability to stop pipeline simulation #78183

alisonelizabeth commented Sep 22, 2020

elasticmachine commented Sep 22, 2020

jloleysens left a comment •

edited

Loading

jloleysens Sep 23, 2020

mdefazio commented Sep 24, 2020

alisonelizabeth commented Sep 28, 2020

mdefazio left a comment

alisonelizabeth commented Sep 29, 2020

kibanamachine commented Sep 29, 2020

mdefazio left a comment

[Ingest pipelines] Add ability to stop pipeline simulation #78183

[Ingest pipelines] Add ability to stop pipeline simulation #78183

Conversation

alisonelizabeth commented Sep 22, 2020

How to test

Screenshots

elasticmachine commented Sep 22, 2020

jloleysens left a comment • edited Loading

Choose a reason for hiding this comment

jloleysens Sep 23, 2020

Choose a reason for hiding this comment

mdefazio commented Sep 24, 2020

alisonelizabeth commented Sep 28, 2020

mdefazio left a comment

Choose a reason for hiding this comment

alisonelizabeth commented Sep 29, 2020

kibanamachine commented Sep 29, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

History

mdefazio left a comment

Choose a reason for hiding this comment

jloleysens left a comment •

edited

Loading