Changed rollup tests to use test user rather than elastic super user. #79567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuff-links
added
Feature:Functional Testing
release_note:skip
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
cuff-links
added
release_note:skip
|
@elasticmachine merge upstream |
|
jenkins retest |
|
The test is passing now. Can you review again after it passes again? |
|
@elasticmachine test this |
|
Ran on local works fine and also same on CI, LGTM . |
legrego
reviewed
Dec 3, 2020
I removed the kibana user role to remove redundancy.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
legrego
approved these changes
Dec 3, 2020
|
I also added a bunch of version labels - needs to be backported to those branches as well. Thanks John |
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Dec 3, 2020
…elastic#79567) * removed .only for testing * Added config with minimum permissions. * Removed kibana user role. I removed the kibana user role to remove redundancy. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
3 tasks
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 4, 2020
* master: (28 commits) [Actions] fixes bug where severity is auto selected but not applied to the action in PagerDuty (elastic#84891) Only attempt to rollover signals index if version < builtin version (elastic#84982) skip flaky suite (elastic#84978) skip lens rollup tests Add geo containment tracking alert type (elastic#84151) Changed rollup tests to use test user rather than elastic super user. (elastic#79567) skip 'should allow creation of lens xy chart' elastic#84957 [APM] Add log_level/sanitize_field_names config options to Python Agent (elastic#84810) [Maps] geo line source (elastic#76572) [data.search] Move search method inside session service and add tests (elastic#84715) skip lens drag and drop test. elastic#84941 [Ingest Node Pipelines] Integrate painless autocomplete (elastic#84554) [Lens] allow drag and drop reorder on xyChart for y dimension (elastic#84640) [Lens] Fix error when selecting the current field again (elastic#84817) [Metrics UI] Add metadata tab to node details flyout (elastic#84454) [CI] Enables APM collection (elastic#81731) [Workplace Search] Migrate Sources Schema tree (elastic#84847) Disable checking for conflicts when copying saved objects (elastic#83575) [SECURITY_SOLUTION] delete advanced Policy fields when they are empty (elastic#84368) y18n 4.0.0 -> 4.0.1 (elastic#84905) ...
cuff-links
pushed a commit
that referenced
this pull request
Dec 5, 2020
…#79567) (#84968) * removed .only for testing * Added config with minimum permissions. * Removed kibana user role. I removed the kibana user role to remove redundancy. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Dec 5, 2020
…elastic#79567) * removed .only for testing * Added config with minimum permissions. * Removed kibana user role. I removed the kibana user role to remove redundancy. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cuff-links
pushed a commit
that referenced
this pull request
Dec 8, 2020
…r user. (#79567) (#85096) * Changed rollup tests to use test user rather than elastic super user. (#79567) * removed .only for testing * Added config with minimum permissions. * Removed kibana user role. I removed the kibana user role to remove redundancy. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * Update rollup_jobs.js Made fix to the test to stop page from refreshing after role is added. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
@cuff-links Please update the version labels. |
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #76563
This PR changes all of our Rollup Job functional tests to use a test user rather than the elastic super user.