[data.search] Move search session logic inside session service and add tests #84715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
review
Feature:Search
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
lukasolson
commented
Dec 1, 2020
| @@ -208,10 +239,6 @@ export class BackgroundSessionService { | |||
| update: (sessionId: string, attributes: Partial<BackgroundSessionSavedObjectAttributes>) => | |||
| this.update(sessionId, attributes, deps), | |||
| delete: (sessionId: string) => this.delete(sessionId, deps), | |||
| trackId: (searchRequest: IKibanaSearchRequest, searchId: string, options: ISearchOptions) => | |||
There was a problem hiding this comment.
I believe these are internal and shouldn't be exposed in asScoped since there isn't anywhere we'd be using them externally, which is why I removed them here.
There was a problem hiding this comment.
👍
same would also make total sense on a client side
Dosant
approved these changes
Dec 2, 2020
2 tasks
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Dec 3, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 4, 2020
* master: (28 commits) [Actions] fixes bug where severity is auto selected but not applied to the action in PagerDuty (elastic#84891) Only attempt to rollover signals index if version < builtin version (elastic#84982) skip flaky suite (elastic#84978) skip lens rollup tests Add geo containment tracking alert type (elastic#84151) Changed rollup tests to use test user rather than elastic super user. (elastic#79567) skip 'should allow creation of lens xy chart' elastic#84957 [APM] Add log_level/sanitize_field_names config options to Python Agent (elastic#84810) [Maps] geo line source (elastic#76572) [data.search] Move search method inside session service and add tests (elastic#84715) skip lens drag and drop test. elastic#84941 [Ingest Node Pipelines] Integrate painless autocomplete (elastic#84554) [Lens] allow drag and drop reorder on xyChart for y dimension (elastic#84640) [Lens] Fix error when selecting the current field again (elastic#84817) [Metrics UI] Add metadata tab to node details flyout (elastic#84454) [CI] Enables APM collection (elastic#81731) [Workplace Search] Migrate Sources Schema tree (elastic#84847) Disable checking for conflicts when copying saved objects (elastic#83575) [SECURITY_SOLUTION] delete advanced Policy fields when they are empty (elastic#84368) y18n 4.0.0 -> 4.0.1 (elastic#84905) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves much of the data plugin search service
searchmethod logic that relates to sessions into asearchmethod on the session service and adds unit tests.To me, this makes more sense as a place to have this logic, makes it simpler to test, and also makes it simpler to utilize the
enhancepattern to move this intodata_enhancedin a follow-up PR.Checklist