-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data.search] Move search session logic inside session service and add tests #84715
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
@@ -208,10 +239,6 @@ export class BackgroundSessionService { | |||
update: (sessionId: string, attributes: Partial<BackgroundSessionSavedObjectAttributes>) => | |||
this.update(sessionId, attributes, deps), | |||
delete: (sessionId: string) => this.delete(sessionId, deps), | |||
trackId: (searchRequest: IKibanaSearchRequest, searchId: string, options: ISearchOptions) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these are internal and shouldn't be exposed in asScoped
since there isn't anywhere we'd be using them externally, which is why I removed them here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
same would also make total sense on a client side
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
* master: (28 commits) [Actions] fixes bug where severity is auto selected but not applied to the action in PagerDuty (elastic#84891) Only attempt to rollover signals index if version < builtin version (elastic#84982) skip flaky suite (elastic#84978) skip lens rollup tests Add geo containment tracking alert type (elastic#84151) Changed rollup tests to use test user rather than elastic super user. (elastic#79567) skip 'should allow creation of lens xy chart' elastic#84957 [APM] Add log_level/sanitize_field_names config options to Python Agent (elastic#84810) [Maps] geo line source (elastic#76572) [data.search] Move search method inside session service and add tests (elastic#84715) skip lens drag and drop test. elastic#84941 [Ingest Node Pipelines] Integrate painless autocomplete (elastic#84554) [Lens] allow drag and drop reorder on xyChart for y dimension (elastic#84640) [Lens] Fix error when selecting the current field again (elastic#84817) [Metrics UI] Add metadata tab to node details flyout (elastic#84454) [CI] Enables APM collection (elastic#81731) [Workplace Search] Migrate Sources Schema tree (elastic#84847) Disable checking for conflicts when copying saved objects (elastic#83575) [SECURITY_SOLUTION] delete advanced Policy fields when they are empty (elastic#84368) y18n 4.0.0 -> 4.0.1 (elastic#84905) ...
Summary
Moves much of the data plugin search service
search
method logic that relates to sessions into asearch
method on the session service and adds unit tests.To me, this makes more sense as a place to have this logic, makes it simpler to test, and also makes it simpler to utilize the
enhance
pattern to move this intodata_enhanced
in a follow-up PR.Checklist