-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Fix networkTopNFlow search strategy response #80362
Merged
patrykkopycinski
merged 10 commits into
elastic:master
from
patrykkopycinski:fix/network-search-strategy
Oct 14, 2020
Merged
[Security Solution] Fix networkTopNFlow search strategy response #80362
patrykkopycinski
merged 10 commits into
elastic:master
from
patrykkopycinski:fix/network-search-strategy
Oct 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/siem (Team:SIEM) |
XavierM
reviewed
Oct 13, 2020
...ck/plugins/security_solution/public/timelines/components/field_renderers/field_renderers.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Oct 13, 2020
...rity_solution/server/search_strategy/security_solution/factory/network/top_n_flow/helpers.ts
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Oct 13, 2020
...lugins/security_solution/public/network/components/embeddables/map_tool_tip/map_tool_tip.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Oct 13, 2020
...lugins/security_solution/public/network/components/embeddables/map_tool_tip/map_tool_tip.tsx
Outdated
Show resolved
Hide resolved
XavierM
approved these changes
Oct 14, 2020
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Oct 14, 2020
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Oct 14, 2020
patrykkopycinski
added a commit
that referenced
this pull request
Oct 14, 2020
patrykkopycinski
added a commit
that referenced
this pull request
Oct 14, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 15, 2020
* master: (102 commits) [Resolver] Fix flaky test (elastic#80576) Update Security Solution Bug Report Template (elastic#80668) [Observability] Kibana home page Observability link pointing to `/landing` (elastic#80636) [APM] Update User Experience app callout code to reflect new name (elastic#80641) [APM] Add missing ML privileges (elastic#80553) [DOCS] Adds intro line to the ML plugin readme file (elastic#80631) [ML] Functional tests - fix and re-enable validation API tests (elastic#80617) remove non-existing dependency from uptime plugin (elastic#80623) [ML] Fix job selection flyout overflow (elastic#80621) Move dashboard code in codeowner files to canvas team (elastic#80345) [Security Solution][Detections] Update signals template if outdated and rollover indices (elastic#80019) Sort service list by TPM if health is not shown (elastic#80447) Add in cluster version for sec telemetry sender. (elastic#80545) [Usage Collection] Usage collection add saved objects client to collector fetch context (elastic#80554) Change tag from experimental to beta (elastic#80443) [Metrics UI] Inventory view cleanup (elastic#79881) [Security Solutions][Detection Engine] Critical bug where value lists were not operational (elastic#80368) [Security Solution] Fix networkTopNFlow search strategy response (elastic#80362) [build] Retry docker pull (elastic#80432) add template for Security Solution bugs (elastic#80574) ...
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:SIEM
Team:Threat Hunting
Security Solution Threat Hunting Team
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously with graphQL
GeoItem
ECS was returning data instring[]
format that was broken during the refactoring to use Search Strategy. This PR fixes that issue + make the types around search strategy response more strict.Also fixes
#64961
#63345
#56716
Before:

After:

Checklist