Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Cases] Cypress for case connector selector options #80745

Merged
merged 7 commits into from
Dec 1, 2020
Merged

[Security Solution] [Cases] Cypress for case connector selector options #80745

merged 7 commits into from
Dec 1, 2020

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 15, 2020 •
edited
Loading

Summary

Cypress tests for connector incident fields in cases, see original PR: #77327

Screen Shot 2020-10-15 at 2 13 23 PM

Checklist

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Oct 15, 2020
@stephmilovic stephmilovic requested review from a team as code owners October 15, 2020 20:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

stephmilovic
stephmilovic commented Oct 15, 2020
View reviewed changes
x-pack/plugins/security_solution/cypress/cypress.json Outdated
@@ -1,6 +1,7 @@
{
"baseUrl": "http://localhost:5601",
"defaultCommandTimeout": 120000,
"experimentalNetworkStubbing": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See here: https://docs.cypress.io/api/commands/route2.html#Comparison-to-cy-route

I'm using an "experimental feature", route2, which allows for dynamic stubbing. I need this in order to stub different responses depending on request params

cnasikas
cnasikas reviewed Oct 16, 2020
View reviewed changes
x-pack/plugins/security_solution/cypress/integration/cases_connector_options.spec.ts Outdated
before(() => {
cy.server();
cy.route('GET', '**/api/cases/configure/connectors/_find', mockConnectorsResponse);
cy.route2('POST', `**/api/actions/action/${ids.jira}/_execute`, (req) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@cnasikas
Copy link
Member

@elasticmachine merge upstream

@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 43133 43135 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 99ea48f into elastic:master Dec 1, 2020
@stephmilovic stephmilovic mentioned this pull request Dec 1, 2020
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Dec 1, 2020
@stephmilovic
[Security Solution] [Cases] Cypress for case connector selector optio…
02f19eb 
…ns (elastic#80745)
stephmilovic added a commit that referenced this pull request Dec 1, 2020
@stephmilovic
[Security Solution] [Cases] Cypress for case connector selector optio…
e874c6f 
…ns (#80745) (#84649)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 1, 2020
@gmmorris
Merge branch 'master' into alerts/custom-recovery-action-group
3421a0f 
* master: (63 commits)
  Revert the Revert of "[Alerting] renames Resolved action group to Recovered (elastic#84123)"  (elastic#84662)
  declare kbn/monaco dependency on kbn/i18n explicitly (elastic#84660)
  Remove unscripted fields from sample data index-pattern saved objects (elastic#84659)
  [ML] Fix unnecessary trigger of wildcard field type search for ML plugin routes. (elastic#84605)
  Update create.asciidoc (elastic#84046)
  [Security Solution][Detections] Fix labels and issue with mandatory fields (elastic#84525)
  Fix flaky test suite (elastic#84602)
  [Security Solution] [Detections] Create a 'partial failure' status for rules (elastic#84293)
  Revert "[Alerting] renames Resolved action group to Recovered (elastic#84123)"
  Update code-comments describing babel plugins (elastic#84622)
  [Security Solution] [Cases] Cypress for case connector selector options (elastic#80745)
  [Discover] Unskip doc table tests (elastic#84564)
  [Lens] (Accessibility) Improve landmarks in Lens (elastic#84511)
  [Lens] (Accessibility) Focus mistakenly stops on righthand form (elastic#84519)
  Return early when parallel install process detected (elastic#84190)
  [Security Solution][Detections] Support arrays in event fields for Severity/Risk overrides (elastic#83723)
  [Security Solution][Detections] Fix grammatical error in validation message for threshold field in "Create new rule" -> "Define rule" (elastic#84490)
  [Fleet] Update agent details page  (elastic#84434)
  adding documentation of use of NODE_EXTRA_CA_CERTS env var (elastic#84578)
  [Search] Integrate "Send to background" UI with session service (elastic#83073)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas left review comments

@MadameSheema MadameSheema MadameSheema approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stephmilovic @elasticmachine @cnasikas @kibanamachine @MadameSheema @MindyRS