declare kbn/monaco dependency on kbn/i18n explicitly

[mshustov]

Summary

after #80577 yarn kbn bootstrap fails locally with

ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 1: /usr/local/Cellar/yarn/1.21.1/libexec/bin/yarn.js run kbn:bootstrap
      error Command failed with exit code 1.
      error Command failed with exit code 1.
      $ yarn build --dev
      $ node ./scripts/build.js --dev
       info Deleting old output
       info [worker] > webpack --config /Users/mikhailshustov/work/kibana/packages/kbn-monaco/webpack.config.js --env.dev
       info [worker] exited with 0 after a few seconds
       info [tsc   ] > tsc
       proc [tsc   ] src/painless/worker/lib/autocomplete.ts(20,22): error TS7016: Could not find a declaration file for module '@kbn/i18n'. '/Users/mikhailshustov/work/kibana/packages/kbn-i18n/target/node/index.js' implicitly has an 'any' type.
       proc [tsc   ]   Try `npm i --save-dev @types/kbn__i18n` if it exists or add a new declaration (.d.ts) file containing `declare module '@kbn/i18n';`
      ERROR UNHANDLED ERROR
      ERROR Error: [tsc   ] exited with code 2

because @kbn/monaco imports @kbn/i18n but doesn't list it in dependencies section

[mshustov]

@elastic/kibana-operations is it possible to detect such cases on CI?

[spalger]

We definitely run yarn kbn bootstrap in CI, do you have any idea why this isn't failing when CI bootstraps?

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 4fb4182

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[spalger]

Looks like the issue is a race condition between the bootstrap step for @kbn/i18n and @kbn/monaco. Because they have similar dependencies the bootstrap scripts start at similar times and on CI it seems that @kbn/i18n finished first causing the @kbn/monaco bootstrap task to complete successfully. The only way to test and prevent this would be to use something like eslint and validate that all dependencies are declared, which we can consider, but it's not going to be an easy thing to turn on and will likely require some code to get working.

[alisonelizabeth]

LGTM. Thanks for fixing this!