[ML] Fix the browser's history navigation #80902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui (:ml) |
|
Noticed after updating the refresh interval, the back button doesn't work any more... The rest seems to work pretty well!
|
darnautov
added
release_note:skip
peteharverson
approved these changes
Oct 19, 2020
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
walterra
approved these changes
Oct 19, 2020
This was referenced Oct 19, 2020
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Oct 19, 2020
* [ML] fix data picker and refresh state * [ML] fix default pause value * [ML] fix jest test * [ML] global state as a source of truth for refreshInterval
darnautov
added a commit
that referenced
this pull request
Oct 19, 2020
darnautov
added a commit
that referenced
this pull request
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes regressions introduced by several PRs during 7.10, where it was no longer possible to return to the previous page in the browser's history by using the Back button.
Some highlights:
value: 0withpause:false. It was causing invoking the callback in a loop in some cases.DatePickerWrapperintroduced collision of states and led to loop updatestimefilterservice were producing some unnecessary states updateRelated #73261.
Checklist