Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add exact match filtering to in-memory tables #81539

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

jen-huang
Copy link
Contributor

Summary

Fixes #70575. This PR changes the filter options of in-memory tables to be exact match (by default it is partial match). This allows the blank integration filter option on Data Streams table to work properly:

image

@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.11.0 labels Oct 22, 2020
@jen-huang jen-huang requested a review from a team October 22, 2020 21:42
@jen-huang jen-huang self-assigned this Oct 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@@ -69,13 +64,8 @@ export const PackagePoliciesTable: React.FunctionComponent<Props> = ({
namespacesValues.push(packagePolicy.namespace);
}

const dsInputTypes: string[] = [];
Copy link
Contributor Author

@jen-huang jen-huang Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't populate any options for this filter, so I just removed the dead code

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ingestManager 1.2MB 1.2MB -200.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.10.0 v7.11.0 v8.0.0
Projects
None yet
4 participants