-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add exact match filtering to in-memory tables #81539
Merged
jen-huang
merged 1 commit into
elastic:master
from
jen-huang:ingest/fix/blank-integration
Oct 23, 2020
Merged
[Fleet] Add exact match filtering to in-memory tables #81539
jen-huang
merged 1 commit into
elastic:master
from
jen-huang:ingest/fix/blank-integration
Oct 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
bug
Fixes for quality problems that affect the customer experience
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.10.0
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.11.0
labels
Oct 22, 2020
Pinging @elastic/ingest-management (Team:Ingest Management) |
jen-huang
commented
Oct 22, 2020
@@ -69,13 +64,8 @@ export const PackagePoliciesTable: React.FunctionComponent<Props> = ({ | |||
namespacesValues.push(packagePolicy.namespace); | |||
} | |||
|
|||
const dsInputTypes: string[] = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we didn't populate any options for this filter, so I just removed the dead code
jfsiii
approved these changes
Oct 23, 2020
This was referenced Oct 23, 2020
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Oct 23, 2020
jen-huang
added a commit
that referenced
this pull request
Oct 23, 2020
jen-huang
added a commit
that referenced
this pull request
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.10.0
v7.11.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #70575. This PR changes the filter options of in-memory tables to be exact match (by default it is partial match). This allows the blank integration filter option on Data Streams table to work properly: