[Ingest Manager] Switch DefaultPackage enum to approach from #82188 #82512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jfsiii
added
release_note:skip
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
jonathan-buttner
approved these changes
Nov 4, 2020
paul-tavares
approved these changes
Nov 4, 2020
jfsiii
pushed a commit
that referenced
this pull request
Nov 5, 2020
…82512) (#82684) ## Summary Follow pattern from #82188. Same behavior as now. Stronger type safety. * `defaultPackages` is runtime value (JS object) * `DefaultPackage` is TS type (`typeof defaultPackages`) * `ValueOf<DefaultPackage>` is TS union type `'system' | 'endpoint'` * Can access values directly as `defaultPackages.System` (JS) or `DefaultPackage['System']` (TS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow pattern from #82188. Same behavior as now. Stronger type safety.
defaultPackagesis runtime value (JS object)DefaultPackageis TS type (typeof defaultPackages)ValueOf<DefaultPackage>is TS union type'system' | 'endpoint'defaultPackages.System(JS) orDefaultPackage['System'](TS)