Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Ingest Manager] Switch DefaultPackage enum to approach from #82188 (#82512) #82684

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Nov 5, 2020

Backports the following commits to 7.x:

…82512)

## Summary

Follow pattern from #82188. Same behavior as now. Stronger type safety.

 * `defaultPackages` is runtime value (JS object)
 * `DefaultPackage` is TS type (`typeof defaultPackages`)
 * `ValueOf<DefaultPackage>` is TS union type `'system' | 'endpoint'`
 * Can access values directly as `defaultPackages.System` (JS) or `DefaultPackage['System']` (TS)
@jfsiii jfsiii added the backport label Nov 5, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ingestManager 1.2MB 1.2MB +2.0B

page load bundle size

id before after diff
ingestManager 385.9KB 385.8KB -178.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii jfsiii merged commit cbe92eb into elastic:7.x Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants