Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(NA): removes auto install of pre-commit hook #83566

Merged
merged 50 commits into from
Dec 4, 2020
Merged

chore(NA): removes auto install of pre-commit hook #83566

merged 50 commits into from
Dec 4, 2020

Conversation

mistic
Copy link
Member

@mistic mistic commented Nov 17, 2020

It closes #81504

That PR removes the auto install of the pre-commit hook and discussed in the mentioned issue and as part of our #69706 effort.

Additionally it adds to new flags (--ref and --maxFiles) into run_precommit_hook script so we can run those checks against a given git ref and skipping it when the listed files to check against exceed a certain value. Those two added flags enabled us to add a new CI check called Quick Commit Checks that intends to give an earlier feedback for the things previously checked for everyone in the pre-commit hook.

After that change, the pre-commit hook is still possible to be installed by manually run node scripts/register_git_hook locally.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 17, 2020
@mistic mistic requested a review from a team as a code owner November 17, 2020 17:27
@mistic mistic self-assigned this Nov 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic
Copy link
Member Author

mistic commented Nov 17, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Nov 24, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Nov 30, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Dec 2, 2020

@elasticmachine merge upstream

@mistic mistic mentioned this pull request Dec 2, 2020
Merged
tylersmalley
tylersmalley approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mistic
Copy link
Member Author

mistic commented Dec 3, 2020

@elasticmachine merge upstream

@mistic mistic mentioned this pull request Dec 3, 2020
Closed
@mistic
Copy link
Member Author

mistic commented Dec 3, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Dec 4, 2020

@elasticmachine merge upstream

@mistic
Copy link
Member Author

mistic commented Dec 4, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.1MB 1.1MB -34.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 60.4KB 60.3KB -34.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 9c3ca20 into elastic:master Dec 4, 2020
@mistic
Copy link
Member Author

mistic commented Dec 4, 2020 •
edited
Loading

7.x: ff03b5b

mistic added a commit to mistic/kibana that referenced this pull request Dec 4, 2020
@mistic @kibanamachine
chore(NA): removes auto install of pre-commit hook (elastic#83566)
2f754ac 
* chore(NA): remove kibana pre-commit hook installation from bootstrap

* chore(NA): add support for git ref flag on run precommit hook script

* chore(NA): integrate quick commit checks within the CI

* chore(NA): introduce logging trap to warn about quick commit checks failure and how to reproduce it

* chore(NA): update quick commit checks message

* fix(NA): quick commit checks function def

* chore(NA): fix quick commit checks message quotes

* chore(NA): fix functional call

* chore(NA): fix script to run

* chore(NA): add unexpected debugger statement to test quick commit checks

* chore(NA): update message to log before quick commit checks

* chore(NA): remove extra debugger statement

* chore(NA): add echo message inline with script execution

* chore(NA): add unexpected debugger statement to test quick commit checks

* chore(NA): remove extra usage of debug statement

* chore(NA): wrapping quick commit checks in a func

* chore(NA): export function to use later

* chore(NA): export function to use later

* chore(NA): use child bash script on github checks reporter

* chore(NA): define dir context for commit_check_runner.sh

* fix(NA): permissions for commit_check_runner.sh

* fix(NA): permissions for commit.sh

* chore(NA): format message to log

* chore(NA): add unexpected debugger statement to test quick commit checks

* chore(NA): remove extra usage of debug statement

* chore(NA): format runner message

* chore(NA): replace log.info by log.warning

* docs(NA): include docs for removing the pre-commit hook auto installation

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@mistic mistic mentioned this pull request Dec 4, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 4, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/snapshot-…
d03bfdb 
…fields

* 'master' of github.com:elastic/kibana:
  [ILM] Fix delete phase serialization bug (elastic#84870)
  chore(NA): removes auto install of pre-commit hook (elastic#83566)
  chore(NA): upgrade node-sass into last v4.14.1 to stop shipping old node-gyp (elastic#84935)
  [Alerting] Enables AlertTypes to define the custom recovery action groups (elastic#84408)
  [ML] Functional tests - add missing test data cleanup (elastic#84998)
  Migrate privilege/role/user-related operations to a new Elasticsearch client. (elastic#84641)

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/deserializer_and_serializer.test.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/serializer/serializer.ts
mistic added a commit that referenced this pull request Dec 4, 2020
@mistic @kibanamachine
chore(NA): removes auto install of pre-commit hook (#83566) (#85026)
ff03b5b 
* chore(NA): remove kibana pre-commit hook installation from bootstrap

* chore(NA): add support for git ref flag on run precommit hook script

* chore(NA): integrate quick commit checks within the CI

* chore(NA): introduce logging trap to warn about quick commit checks failure and how to reproduce it

* chore(NA): update quick commit checks message

* fix(NA): quick commit checks function def

* chore(NA): fix quick commit checks message quotes

* chore(NA): fix functional call

* chore(NA): fix script to run

* chore(NA): add unexpected debugger statement to test quick commit checks

* chore(NA): update message to log before quick commit checks

* chore(NA): remove extra debugger statement

* chore(NA): add echo message inline with script execution

* chore(NA): add unexpected debugger statement to test quick commit checks

* chore(NA): remove extra usage of debug statement

* chore(NA): wrapping quick commit checks in a func

* chore(NA): export function to use later

* chore(NA): export function to use later

* chore(NA): use child bash script on github checks reporter

* chore(NA): define dir context for commit_check_runner.sh

* fix(NA): permissions for commit_check_runner.sh

* fix(NA): permissions for commit.sh

* chore(NA): format message to log

* chore(NA): add unexpected debugger statement to test quick commit checks

* chore(NA): remove extra usage of debug statement

* chore(NA): format runner message

* chore(NA): replace log.info by log.warning

* docs(NA): include docs for removing the pre-commit hook auto installation

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees

@mistic mistic

Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[discuss] Changes to pre-commit hook
5 participants
@mistic @elasticmachine @kibanamachine @tylersmalley @spalger