Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - add missing test data cleanup #84998

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Dec 4, 2020

Summary

This PR adds a few missing cleanup calls to the after methods of the functional ML test suite and the functional basic ML test suite.

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 4, 2020
@pheyos pheyos self-assigned this Dec 4, 2020
@pheyos pheyos requested a review from a team as a code owner December 4, 2020 08:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit b9b2704 into elastic:master Dec 4, 2020
@pheyos pheyos deleted the add_missing_cleanup branch December 4, 2020 13:40
pheyos added a commit to pheyos/kibana that referenced this pull request Dec 4, 2020
This PR adds a few missing cleanup calls to the after methods of the functional ML test suite and the functional basic ML test suite.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 4, 2020
…fields

* 'master' of github.com:elastic/kibana:
  [ILM] Fix delete phase serialization bug (elastic#84870)
  chore(NA): removes auto install of pre-commit hook (elastic#83566)
  chore(NA): upgrade node-sass into last v4.14.1 to stop shipping old node-gyp (elastic#84935)
  [Alerting] Enables AlertTypes to define the custom recovery action groups (elastic#84408)
  [ML] Functional tests - add missing test data cleanup (elastic#84998)
  Migrate privilege/role/user-related operations to a new Elasticsearch client. (elastic#84641)

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/deserializer_and_serializer.test.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/serializer/serializer.ts
pheyos added a commit that referenced this pull request Dec 4, 2020
This PR adds a few missing cleanup calls to the after methods of the functional ML test suite and the functional basic ML test suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants