[Monitoring] Fix small issue with detecting missing monitoring data from APM #83646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
release_note:fix
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
igoristic
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
@chrisronline Approved, but isn't this fix kinda irrelevant with #83659?
|
@igoristic Agreed, but I didn't want to forget this fix when we came back to re-adding this alert for APM. |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Nov 19, 2020
…tic#83646) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Nov 19, 2020
…tic#83646) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Nov 19, 2020
…tic#83646) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline
added a commit
that referenced
this pull request
Nov 19, 2020
…) (#83832) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
chrisronline
added a commit
that referenced
this pull request
Nov 19, 2020
…) (#83831) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #83309
We made a small typo when retrieving the beat type, which is necessary to detect APM versus regular beats.
This wasn't caught in our testing because we explicitly set the field which overrides the bug we're fixing here.