[Monitoring] Only look at ES for the missing data alert for now #83659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
release_note:fix
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
@elasticmachine merge upstream |
|
@chrisronline I am thinking that we should modify the "looking back" period for this alert from 1 day to 6 hours. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
igoristic
reviewed
Nov 19, 2020
There was a problem hiding this comment.
@chrisronline I think we should also optimize (remove none es logic) in: x-pack/plugins/monitoring/server/lib/alerts/fetch_missing_monitoring_data.ts and make it only look in .monitoring-es-* indices, which should make it significantly faster
…on (elastic#83507) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* update deps * update rules use type-aware @typescript-eslint/no-shadow instead of no-shadow. do not use no-undef, rely on TypeScript instead * fix or mute all lint errors * react-hooks eslint plugin fails on ? syntax * fix wrong typings in viz * remove React as a global type * fix eslint errors * update version to 4.8.1 * fix a new error
…ic#82638) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [APM] Improve router types * Pass processorEvent param to useDynamicIndexPattern
* Initial copy/paste of source logic Only changed lodash imports and import order for linting * Add types and route * Update paths and typings Renamed IMeta -> Meta Used object instead of IObject * Remove internal flash messages in favor of globals - All instances of flashAPIErrors(e) are only placeholders until the later commit removing axios. - buttonLoading was set to false when the error flash messages were set. For now I added a `setButtonNotLoading` action to do this manually in a finally block. This will be refactored once axios is removed. - SourcesLogic is no longer needed because we set a queued flash message instead of trying to set it in SourcesLogic, which no longer has local flash messages * Add return types to callback definitions * Update routes According to the API info getSourceReConnectData is supposed to send the source ID and not the service type. In the template, we are actually sending the ID but the logic file parameterizes it as serviceType. This is fixed here. Usage: https://github.com/elastic/ent-search/blob/master/app/javascript/workplace_search/ContentSources/components/AddSource/ReAuthenticate.tsx#L38 * Replace axios with HttpLogic Also removes using history in favor of KibanaLogic’s navigateToUrl * Fix incorrect type This selector is actually an array of strings * Create GenericObject to satisfy TypeScript Previously in `ent-search`, we had a generic `IObject` interface that we could use on keyed objects. It was not migrated over since it uses `any` and Kibana has a generic `object` type we can use in most situations. However, when we are checking for keys in our code, `object` does not work. This commit is an attempt at making a generic interface we can use. * More strict object typing Removes GenericObject from last commit and adds stricter local typing * Add i18n Also added for already-merged SourcesLogic * Move button loading action to finally block * Move route strings to inline
… edit (elastic#83578) * Adding alert.updatedAt field that only updates on user edit * Updating unit tests * Functional tests * Updating alert attributes excluded from AAD * Fixing test * PR comments
botelastic
bot
added
Feature:Embedding
|
Pinging @elastic/apm-ui (Team:apm) |
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
|
Pinging @elastic/uptime (Team:uptime) |
chrisronline
removed
Feature:Embedding
|
Sorry folks, bad merge. Replaced by #83839 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #83309
Until we can come up with a strategy to detect upgrades versus legitimate downed stack products, we are changing the missing monitoring data alert to only apply to Elasticsearch, as upgrades to Elasticsearch typically persist node ids.
To test, I'd recommend creating a cloud deployment on a version that is less than the current one. Configure your local Kibana's monitoring settings to read monitoring data from this deployment. Then, upgrade the cloud deployment and ensure we don't see any missing monitoring data alerts.