Fixes incomplete client cert chain when using PKI authentication with the login selector #88229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did not change assertions, just refactored in preparation for the next commit.
When an incomplete client cert chain is detected and the TLS protocol version supports it (1.0-1.2), renegotiate the connection to trigger a new TLS handshake and attempt to obtain the full client cert chain.
afharo
reviewed
Jan 13, 2021
| return this.socket instanceof TLSSocket ? this.socket.authorizationError : undefined; | ||
| } | ||
|
|
||
| constructor(public readonly socket: Socket) {} |
There was a problem hiding this comment.
Do we intentionally make the socket public (it was private)?
There was a problem hiding this comment.
😬 Nope, that was intended to be a temporary change while I was testing how renegotiate worked. Thanks for catching, I'll change that back.
Edit: done in 044a062.
legrego
reviewed
Jan 13, 2021
legrego
approved these changes
Jan 13, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
mshustov
approved these changes
Jan 14, 2021
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Jan 14, 2021
… the login selector (elastic#88229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #88100.
This PR introduces new behavior in the PKI authenticator when an incomplete client cert chain is detected. It now attempts to renegotiate the connection one time to retrieve the full client cert chain. This only works when using TLS 1.0-1.2, as TLS 1.3 does not support renegotiation.
Testing: see linked issue.
Debug logs scenario 1 (normal PKI auth obtains full cert chain)
Debug logs scenario 2 (TLS 1.2, renegotiated connection for PKI auth to obtain full cert chain)
Debug logs scenario 3 (TLS 1.3, cannot renegotiate connection, PKI auth obtains incomplete cert chain)