Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [TileMap][RegionMap] Implement custom renderers and expression builders (#84775) #88308

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

sulemanof
Copy link
Contributor

Backports the following commits to 7.x:

…rs (elastic#84775)

* Convert to typescript

* Move related files directly into plugin

* Implement toExpressionAst

* Remove build_pipeline dedicated fn

* Async import converter

* Create a custom renderer

* Remove ExprVis instance usage in maps visualizations

* Use uiState updates

* Create wrapper component

* Update rendering

* Create region map expression renderer

* Remove resize subscription

* Fix custom visualization expression

* Update interpreter functional tests

* Use types from geojson

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
mapsLegacy 188 183 -5
regionMap 15 30 +15
tileMap 21 39 +18
total +28

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
mapsLegacy 722.1KB 721.9KB -224.0B
regionMap 260.2KB 293.1KB +32.9KB
tileMap 258.5KB 291.8KB +33.3KB
total +66.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 200.8KB 200.8KB +1.0B
mapsLegacy 94.3KB 89.1KB -5.3KB
regionMap 44.4KB 29.3KB -15.1KB
tileMap 44.5KB 27.8KB -16.7KB
visualizations 171.3KB 170.4KB -932.0B
total -38.0KB
Unknown metric groups

async chunk count

id before after diff
regionMap 1 3 +2
tileMap 1 4 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit ae139f9 into elastic:7.x Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants