[TileMap][RegionMap] Implement custom renderers and expression builders #84775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
December 1, 2020 18:47
# Conflicts: # src/plugins/region_map/public/region_map_fn.ts # src/plugins/tile_map/public/tile_map_fn.test.ts # src/plugins/tile_map/public/tile_map_fn.ts
13 tasks
sulemanof
changed the title
botelastic
bot
added
the
Feature:ExpressionLanguage
stratoula
reviewed
Dec 24, 2020
stratoula
approved these changes
Dec 24, 2020
|
@elasticmachine merge upstream |
alexwizp
approved these changes
Dec 29, 2020
kindsun
reviewed
Dec 29, 2020
| }); | ||
| this._leafletMap.on('load', () => { | ||
| visualization.sessionState.mapBounds = this.getBounds(); | ||
| }); | ||
| this.on('dragend', persistMapStateInUiState); |
There was a problem hiding this comment.
Are these changes being captured somewhere else now?
There was a problem hiding this comment.
I didn't find any other usages of sessionState except this place, so I think this is just a legacy leftover which should. be removed
|
Overall some nice clean up, shuffling of existing logic and additions in this PR. Lazy loading is a great add 💯. Posted some minor comments but local tests all appear to work as expected!
|
|
@elasticmachine merge upstream |
# Conflicts: # src/plugins/tile_map/public/tile_map_type.ts
alexwizp
reviewed
Jan 11, 2021
alexwizp
reviewed
Jan 11, 2021
|
@aaronjcaldwell @nreese please review that. We need a review from your team |
nreese
approved these changes
Jan 13, 2021
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
History
To update your PR or re-run it, just comment with: |
sulemanof
pushed a commit
that referenced
this pull request
Jan 14, 2021
…rs (#84775) (#88308) * Convert to typescript * Move related files directly into plugin * Implement toExpressionAst * Remove build_pipeline dedicated fn * Async import converter * Create a custom renderer * Remove ExprVis instance usage in maps visualizations * Use uiState updates * Create wrapper component * Update rendering * Create region map expression renderer * Remove resize subscription * Fix custom visualization expression * Update interpreter functional tests * Use types from geojson Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #46801
Implement custom renderers and expression builders for the
Tile Map&Region Mapvisualizations.The PR includes next changes:
Tile Map plugin
src/plugins/tile_map/public/to_ast.ts;src/plugins/tile_map/public/tile_map_renderer.tsx;TileMapOptionscomponent for editor;decodeGeoHash,geoContains,convertToGeoJsonwere moved directly intotile_mapplugin, since they are only used there;src/plugins/tile_map/public/_tile_map.scss;Region Map plugin
src/plugins/region_map/public/to_ast.ts;src/plugins/region_map/public/region_map_renderer.tsx;RegionMapOptionscomponent for editor;Maps legacy plugin
BaseMapsVisualizationparent class to useIInterpreterRenderHandlersandVisParamsinstead ofExprVisinstance - which will be removed in visualizations cleanup;KibanaMapclass to useuiStateobject directly;Checklist
Delete any items that are not applicable to this PR.
For maintainers