[Security Solution][Exceptions] - Remove exceptions table search #88784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yctercero
added
bug
spong
added
release_note:skip
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
spong
pushed a commit
to spong/kibana
that referenced
this pull request
Jan 20, 2021
…tic#88784 (elastic#88784) ## Summary Temporarily addresses elastic#88450 A follow PR will address full fix. ### Issue Exceptions table search not functioning as expected. ### Diagnostic The exception list SO properties are mapped as keywords, meaning ES does not tokenize them. Need to add a `text` mapping for fields we want to search on in order for search to work as expected. Expectations for exceptions table search being: - I can search `Endpoint Security` and get results that match `Endpoint` or `Security` - I can search `"Endpoint Security"` and it will conduct an exact match search It's too late in the release cycle for mappings updates - a follow up PR will properly fix search. ### Without Search <img width="1766" alt="Screen Shot 2021-01-19 at 7 52 01 PM" src="https://user-images.githubusercontent.com/10927944/105112279-aed64300-5a90-11eb-95fc-1922eb2055e9.png"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This was referenced Jan 20, 2021
Merged
spong
pushed a commit
to spong/kibana
that referenced
this pull request
Jan 20, 2021
…tic#88784 (elastic#88784) ## Summary Temporarily addresses elastic#88450 A follow PR will address full fix. ### Issue Exceptions table search not functioning as expected. ### Diagnostic The exception list SO properties are mapped as keywords, meaning ES does not tokenize them. Need to add a `text` mapping for fields we want to search on in order for search to work as expected. Expectations for exceptions table search being: - I can search `Endpoint Security` and get results that match `Endpoint` or `Security` - I can search `"Endpoint Security"` and it will conduct an exact match search It's too late in the release cycle for mappings updates - a follow up PR will properly fix search. ### Without Search <img width="1766" alt="Screen Shot 2021-01-19 at 7 52 01 PM" src="https://user-images.githubusercontent.com/10927944/105112279-aed64300-5a90-11eb-95fc-1922eb2055e9.png"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
peluja1012
pushed a commit
that referenced
this pull request
Jan 20, 2021
… (#88784) (#88795) ## Summary Temporarily addresses #88450 A follow PR will address full fix. ### Issue Exceptions table search not functioning as expected. ### Diagnostic The exception list SO properties are mapped as keywords, meaning ES does not tokenize them. Need to add a `text` mapping for fields we want to search on in order for search to work as expected. Expectations for exceptions table search being: - I can search `Endpoint Security` and get results that match `Endpoint` or `Security` - I can search `"Endpoint Security"` and it will conduct an exact match search It's too late in the release cycle for mappings updates - a follow up PR will properly fix search. ### Without Search <img width="1766" alt="Screen Shot 2021-01-19 at 7 52 01 PM" src="https://user-images.githubusercontent.com/10927944/105112279-aed64300-5a90-11eb-95fc-1922eb2055e9.png"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
peluja1012
pushed a commit
that referenced
this pull request
Jan 20, 2021
… (#88784) (#88794) ## Summary Temporarily addresses #88450 A follow PR will address full fix. ### Issue Exceptions table search not functioning as expected. ### Diagnostic The exception list SO properties are mapped as keywords, meaning ES does not tokenize them. Need to add a `text` mapping for fields we want to search on in order for search to work as expected. Expectations for exceptions table search being: - I can search `Endpoint Security` and get results that match `Endpoint` or `Security` - I can search `"Endpoint Security"` and it will conduct an exact match search It's too late in the release cycle for mappings updates - a follow up PR will properly fix search. ### Without Search <img width="1766" alt="Screen Shot 2021-01-19 at 7 52 01 PM" src="https://user-images.githubusercontent.com/10927944/105112279-aed64300-5a90-11eb-95fc-1922eb2055e9.png"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Temporarily addresses #88450
A follow PR will address full fix.
Issue
Exceptions table search not functioning as expected.
Diagnostic
The exception list SO properties are mapped as keywords, meaning ES does not tokenize them. Need to add a
textmapping for fields we want to search on in order for search to work as expected. Expectations for exceptions table search being:Endpoint Securityand get results that matchEndpointorSecurity"Endpoint Security"and it will conduct an exact match searchIt's too late in the release cycle for mappings updates - a follow up PR will properly fix search.
Without Search
Checklist