Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Security Solution][Exceptions] - Remove exceptions table search #88784 (#88784) #88794

Merged
merged 1 commit into from
Jan 20, 2021
Merged

[7.x] [Security Solution][Exceptions] - Remove exceptions table search #88784 (#88784) #88794

merged 1 commit into from
Jan 20, 2021

Conversation

spong
Copy link
Member

@spong spong commented Jan 20, 2021

Backports the following commits to 7.x:

@yctercero @spong
[Security Solution][Exceptions] - Remove exceptions table search elas…
ca85dbe 
…tic#88784 (elastic#88784)

## Summary

Temporarily addresses elastic#88450

A follow PR will address full fix.

### Issue
Exceptions table search not functioning as expected.

### Diagnostic
The exception list SO properties are mapped as keywords, meaning ES does not tokenize them. Need to add a `text` mapping for fields we want to search on in order for search to work as expected. Expectations for exceptions table search being:
- I can search `Endpoint Security` and get results that match `Endpoint` or `Security`
- I can search `"Endpoint Security"` and it will conduct an exact match search

It's too late in the release cycle for mappings updates - a follow up PR will properly fix search.

### Without Search
<img width="1766" alt="Screen Shot 2021-01-19 at 7 52 01 PM" src="https://user-images.githubusercontent.com/10927944/105112279-aed64300-5a90-11eb-95fc-1922eb2055e9.png">

 
### Checklist

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@spong spong added the backport label Jan 20, 2021
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

Creates a timeline.Timelines Creates a timeline

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 19 times on tracked branches: https://github.com/elastic/kibana/issues/79389

AssertionError: Timed out retrying after 60000ms: expected '<h3>' to have text 'Security Timeline', but the text was 'Untitled timeline'
    at Context.eval (http://localhost:6111/__cypress/tests?p=cypress/integration/timeline_creation.spec.ts:15061:47)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB -1.2KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@peluja1012 peluja1012 merged commit de6159a into elastic:7.x Jan 20, 2021
@spong spong deleted the backport/7.x/pr-88784 branch January 20, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spong @kibanamachine @peluja1012 @yctercero