Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coverage] speed up merging results of functional tests #92111

Merged
merged 15 commits into from
Feb 22, 2021
Merged

[coverage] speed up merging results of functional tests #92111

merged 15 commits into from
Feb 22, 2021

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Feb 20, 2021 •
edited
Loading

Summary

Currently we iterate through json files generated in functional tests and replace basePath with repo checkout path. It takes 28-30 min:

15:37:00  36G	/tmp/extracted_coverage/target/kibana-coverage
15:37:00  ### Functional: replacing path in json files
16:05:38  ### Merge coverage reports

This PR copies kibana to /dev/shm/workspace/ to match basePath in json files and avoid updating these files.

Before:

### Merge coverage reports - (52 min in self)

After:

### Merge coverage reports - (23 min in self)

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dmlemeshko dmlemeshko added backport:skip This commit does not require backporting code coverage Issues & PRs about code coverage release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Feb 20, 2021
@dmlemeshko dmlemeshko marked this pull request as ready for review February 20, 2021 12:35
@dmlemeshko dmlemeshko requested a review from a team as a code owner February 20, 2021 12:35
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

LeeDr
LeeDr approved these changes Feb 22, 2021
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I verified the approximately the same number of docs in the output of this branch vs previous

@dmlemeshko dmlemeshko merged commit 8fb50c9 into elastic:master Feb 22, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 22, 2021
@gmmorris
Merge branch 'master' into alerting/rename-reload-alerts
441445b 
* master:
  Ability to filter alerts by string parameters (elastic#92036)
  [APM] Fix for flaky correlations API test (elastic#91673) (elastic#92094)
  [Enterprise Search] Migrate shared role mapping components (elastic#91723)
  [file_upload] move ml Importer classes to file_upload plugin (elastic#91559)
  [Discover] Always show the "hide missing fields" toggle (elastic#91889)
  v2 migrations should exit process on corrupt saved object document (elastic#91465)
  [ML] Data Frame Analytics exploration page: filters improvements (elastic#91748)
  [ML] Data Frame Analytics: Improved error handling for scatterplot matrix. (elastic#91993)
  [coverage] speed up merging results of functional tests (elastic#92111)
  Adds a Reason indicator to the onClose handler in AddAlert and EditAlert (elastic#92149)
@dmlemeshko dmlemeshko deleted the avoid-updating-json-files branch January 31, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting code coverage Issues & PRs about code coverage release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmlemeshko @kibanamachine @LeeDr