Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Always show the "hide missing fields" toggle #91889

Merged
merged 3 commits into from
Feb 22, 2021
Merged

[Discover] Always show the "hide missing fields" toggle #91889

merged 3 commits into from
Feb 22, 2021

Conversation

wylieconlon
Copy link
Contributor

@wylieconlon wylieconlon commented Feb 18, 2021 •
edited
Loading

This behavior will change soon, but as of the time this PR was introduced there are two behaviors:

  1. There is always a "hide missing fields" toggle when using the _source or fields API:

Screen Shot 2021-02-18 at 12 30 06 PM

  1. When using the new fields API with a saved search, you will see two toggles:

Screen Shot 2021-02-18 at 12 28 46 PM

Fixes #91876

Checklist

@wylieconlon wylieconlon added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 labels Feb 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this pull request Feb 19, 2021
Closed
31 tasks
flash1293
flash1293 approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this and works fine for me (would appreciate a second look though)

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

@wylieconlon anything blocking us to merge this?

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 396.9KB 396.8KB -41.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal
kertal approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing when testing it that came to my mind, if we shouldn't change the default of hide missing fields to off in the near future. Since we now do multi field grouping .keywordetc. fields are not part of the top level list. ... or even better, align to the Lens pattern of Available fields, Empty fields, Meta fields :)

@wylieconlon
Copy link
Contributor Author

@kertal Want to open an issue for doing that in a future minor?

@kertal
Copy link
Member

kertal commented Feb 22, 2021 •
edited
Loading

@kertal Want to open an issue for doing that in a future minor?

@wylieconlon done #92208 👍

@wylieconlon wylieconlon merged commit b9de3c7 into elastic:master Feb 22, 2021
@wylieconlon wylieconlon deleted the discover-show-hidden-switch branch February 22, 2021 15:46
This was referenced Feb 22, 2021
Merged
Merged
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Feb 22, 2021
@kibanamachine @wylieconlon
[Discover] Always show the "hide missing fields" toggle (elastic#91889)
be532cd 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 22, 2021
@gmmorris
Merge branch 'master' into alerting/rename-reload-alerts
441445b 
* master:
  Ability to filter alerts by string parameters (elastic#92036)
  [APM] Fix for flaky correlations API test (elastic#91673) (elastic#92094)
  [Enterprise Search] Migrate shared role mapping components (elastic#91723)
  [file_upload] move ml Importer classes to file_upload plugin (elastic#91559)
  [Discover] Always show the "hide missing fields" toggle (elastic#91889)
  v2 migrations should exit process on corrupt saved object document (elastic#91465)
  [ML] Data Frame Analytics exploration page: filters improvements (elastic#91748)
  [ML] Data Frame Analytics: Improved error handling for scatterplot matrix. (elastic#91993)
  [coverage] speed up merging results of functional tests (elastic#92111)
  Adds a Reason indicator to the onClose handler in AddAlert and EditAlert (elastic#92149)
wylieconlon pushed a commit that referenced this pull request Feb 22, 2021
@kibanamachine
[Discover] Always show the "hide missing fields" toggle (#91889) (#92212
eeafdc8 
)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
wylieconlon pushed a commit that referenced this pull request Feb 22, 2021
@kibanamachine
[Discover] Always show the "hide missing fields" toggle (#91889) (#92211
5668436 
)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@flash1293 flash1293 flash1293 approved these changes

@timroes timroes Awaiting requested review from timroes

@majagrubic majagrubic Awaiting requested review from majagrubic

Assignees
No one assigned
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Discover] Bring back "hide missing fields" toggle when using fields API
5 participants
@wylieconlon @elasticmachine @flash1293 @kibanamachine @kertal