-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XY Charts] limit date histogram ticks on xy charts #93497
Conversation
jenkins retest this please |
@elasticmachine merge upstream |
@nickofthyme This PR requires an update of the docs - you have to run |
Ahh thanks @flash1293 |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_filtering·ts.dashboard app using current data dashboard filtering using a pinned filter that excludes all data "before all" hook for "filters on pie charts"Standard Out
Stack Trace
Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_filtering·ts.dashboard app using current data dashboard filtering using a pinned filter that excludes all data "after all" hook for "vega is filtered"Standard Out
Stack Trace
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is not the right approach to limiting the information density of the chart. I thought charts would automatically hide ticks when the labels are too dense, like in this storyboard example.
This approach doesn't let users have any control over the display of their data such as by increasing the width in the dashboard.
Edit: It seems like we are already using the default settings for tick labeling, but maybe the ticks are not padded enough. There's also a long-term change that I'd like to make, maybe in the 8.0 breaking changes, which is to use context-aware formatting for dates.
@wylieconlon you're right maybe this is not the best solution. The chart will filter overlapping values however with data histograms it's possible with wider more uniform labels to run into something like this... Let me try changing the padding and see if that helps avoid this case. I would love to see #51227 come to life. I also think the chart labeling needs to be updated to be more adaptive to show the best label given all the constraints rather than just hiding labels that don't fit. |
Summary
fixes #93493
Adds same tick limit from discover (here), to xy date histogram charts in visualize library.
Before
After