Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Fleet] Fix circular ref by moving code & tests into Fleet (#94171) #94483

Merged
merged 1 commit into from
Mar 11, 2021

Commits on Mar 11, 2021

  1. [Fleet] Fix circular ref by moving code & tests into Fleet (elastic#9…

    …4171)
    
    ## Problem
    There's a circular dependency elastic#91111 between the `fleet` and `security_solution` plugins 
    
    * `security_solution` depends on `fleet`, but 
    * `fleet` has (_had_ with this PR) an `import` from  `security_solution` (migrations for the 7.11 and 7.12 package policy objects)
    
    ## Proposed solution
    ### (A) This PR
    Move the two imported functions from `security` into `fleet`.
    
    ### (B) Follow up issue
    Putting integration-specific code into `fleet` doesn't scale (technically or cognitively). Discuss if this use case (specifying saved object migrations, etc) applies to other plugins. e.g. can `apm` do this? `nginx`? If so, should we find a way to move this out of `fleet`?
    
    
    ### Checklist
    
    - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    
    closes elastic#91111
    Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
    John Schulz authored and kibanamachine committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    26e1858 View commit details
    Browse the repository at this point in the history