Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Stop fetching previous period data when comparison is disabled #97469

Merged
merged 3 commits into from
Apr 19, 2021
Merged

[APM] Stop fetching previous period data when comparison is disabled #97469

merged 3 commits into from
Apr 19, 2021

Conversation

cauemarcondes
Copy link
Contributor

closes #97445

Comparison disabled:
Screen Shot 2021-04-19 at 09 33 16

Comparison enabled:
Screen Shot 2021-04-19 at 09 34 37

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 apm:comparison auto-backport Deprecated - use backport:version if exact versions are needed labels Apr 19, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner April 19, 2021 14:04
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Apr 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes requested a review from sorenlouv April 19, 2021 14:58
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.2MB 4.2MB +179.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 83824ab into elastic:master Apr 19, 2021
@cauemarcondes cauemarcondes deleted the apm-stop-fetching-comparison branch April 19, 2021 21:50
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 19, 2021
@cauemarcondes @kibanamachine
[APM] Stop fetching previous period data when comparison is disabled (e…
e821487 
…lastic#97469)

* stopping fetching previous period data when comparison is disabled

* addressing PR comments

* refactoring comparison and primary API names
@kibanamachine kibanamachine mentioned this pull request Apr 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Apr 19, 2021
@kibanamachine @cauemarcondes
[APM] Stop fetching previous period data when comparison is disabled (#…
9d97f74 
…97469) (#97546)

* stopping fetching previous period data when comparison is disabled

* addressing PR comments

* refactoring comparison and primary API names

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
@cauemarcondes
Copy link
Contributor Author

e2e added here #98291

@ogupte ogupte self-assigned this May 24, 2021
@ogupte ogupte added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte left review comments

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees

@ogupte ogupte

Labels
apm:comparison apm:test-plan-7.13.0 apm:test-plan-done Pull request that was successfully tested during the test plan auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Stop fetching previous period data when comparison is disabled
5 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv @ogupte