New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor issues with bundler specs #15094

Open

jsvd opened this issue Jun 16, 2023 · 0 comments · May be fixed by #15095

Member

jsvd commented Jun 16, 2023

From #15066:

When stubbing behavior with constraints using with, I have a preference for using the fluent interface (and_return, and_raise, etc.) over the block implementation wherever possible
Since we expect the CLI to receive this message with these arguments, using RSpec's expect will make it easier to catch the cause of failure if/when this spec breaks.

        expect(::Bundler::CLI).to receive(:start).with(bundler_args).and_raise( ::Bundler::VersionConflict, 'conflict')

Originally posted by @yaauie in #15066 (comment)

The text was updated successfully, but these errors were encountered:

jsvd added a commit that referenced this issue


          improve bundler specs

097a6eb

closes #15094

jsvd linked a pull request

that will close this issue

improve bundler specs #15095

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment