Remove custom bundler #15066
Merged
Remove custom bundler #15066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
force-pushed
the
remove_custom_bundler
branch
from
87d7568 to
22d9979
Compare
jsvd
commented
Jun 2, 2023
|
I have started a set of tests in CI for this |
yaauie
reviewed
Jun 2, 2023
There was a problem hiding this comment.
I am wary of running integration specs with a different bundler than we use at runtime, since the integration tests include coverage for installing and updating plugins which will use the bundler on the load path. This could lead to integration specs passing or failing independently of the actual behavior of our packaged artifacts.
jsvd
force-pushed
the
remove_custom_bundler
branch
2 times, most recently
from
060085f to
b98846d
Compare
|
PR ready for a new review. I've removed the need to have a separate bundler for integration tests. |
jsvd
force-pushed
the
remove_custom_bundler
branch
from
b98846d to
a1c79c3
Compare
|
jenkins test this please |
yaauie
reviewed
Jun 20, 2023
jsvd
force-pushed
the
remove_custom_bundler
branch
from
a1c79c3 to
1b58557
Compare
jsvd
force-pushed
the
remove_custom_bundler
branch
from
1b58557 to
df68102
Compare
|
jenkins test this please |
This was referenced Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on external bundler because JRuby flutuated between including and not including bundler for a while, now that bundler is part of rubygems, unless there's a CVE afecting the shipped version of bundler there's no need to have a custom one any more.
This simplifies our code and bootstrapping tasks, so this PR removes the need to install bundler during bootstrap.
As side effect this PR reintroduces the older patches to not go OOM during plugin docs generation.
TODO: find a way to not require installing bundler for the QA tests. We can deal with that in a follow up PR