Skip to content

[ML] Upgrade to Boost 1.86.0 on Windows 2022 builds #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 29, 2024
Merged

[ML] Upgrade to Boost 1.86.0 on Windows 2022 builds #2780

merged 11 commits into from
Nov 29, 2024
+47 −38

Conversation

edsavage
Copy link
Contributor

@edsavage edsavage commented Nov 19, 2024 •
edited
Loading

Update build scripts and docs to refer to Boost 1.86

@edsavage
[ML] Upgrade to Boost 1.86.0
eb29852 
Update build cripts and docs to refer to Boost 1.86
@edsavage edsavage changed the title [ML] Upgrade to Boost 1.86.0 [ML] Upgrade to Boost 1.86.0 on Windows 2022 builds Nov 19, 2024
@edsavage edsavage mentioned this pull request Nov 20, 2024
Merged
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@edsavage edsavage marked this pull request as ready for review November 27, 2024 23:29
@edsavage edsavage requested a review from valeriy42 November 27, 2024 23:29
valeriy42
valeriy42 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@valeriy42 valeriy42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You need to be careful when backporting, since 8.18 relies on different base image.

valeriy42
valeriy42 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@valeriy42 valeriy42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edsavage edsavage merged commit 6776b9c into elastic:main Nov 29, 2024
16 checks passed
edsavage added a commit to edsavage/ml-cpp that referenced this pull request Dec 3, 2024
@edsavage
[8.18][ML] Upgrade to Boost 1.86.0 on Windows builds (elastic#2780)
77fb51b 
Update build scripts and docs to refer to Boost 1.86

Backports elastic#2780
@edsavage edsavage mentioned this pull request Dec 3, 2024
Merged
edsavage added a commit that referenced this pull request Dec 5, 2024
@edsavage
[8.18][ML] Windows 2016 boost 1.86 (#2780) (#2791)
73b5186 
Update Windows build scripts, documentation etc. to refer to Boost 1.86.

Backports #2780

Depends on #2783
@edsavage edsavage deleted the windows_2022_boost_1_86 branch March 20, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriy42 valeriy42 valeriy42 approved these changes

Assignees
No one assigned
Labels
>enhancement :ml v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edsavage @valeriy42