Skip to content

[ML] Upgrade to PyTorch 2.5.0 on Windows 2022 builds #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 29, 2024
Merged

[ML] Upgrade to PyTorch 2.5.0 on Windows 2022 builds #2783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
33d9930
Some debug
edsavage Nov 19, 2024
6495aca
Update windows deps build script
edsavage Nov 20, 2024
6c7b22b
Use Boost 1.86.0 on Windows only
edsavage Nov 20, 2024
70408fb
Merge branch 'elastic:main' into windows_2022_pytorch_25
edsavage Nov 20, 2024
cb3567a
Compilation fix
edsavage Nov 21, 2024
7ec0e5f
Merge branch 'windows_2022_pytorch_25' of github.com:edsavage/ml-cpp …
edsavage Nov 21, 2024
0442113
Use latest Windows 2022 VM image
edsavage Nov 21, 2024
1bfa5d8
Fix 3rd party libs
edsavage Nov 21, 2024
19eacca
Update changelog
edsavage Nov 21, 2024
8e24133
Fix for CMemoryUsageTest
edsavage Nov 21, 2024
bde24a9
Merge branch 'main' of github.com:elastic/ml-cpp into windows_2022_py…
edsavage Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .buildkite/pipelines/build_windows.json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def main(args):
"provider": "gcp",
"machineType": "c2-standard-16",
"minCpuPlatform": "Intel Cascade Lake",
"image": "family/ml-cpp-3-windows-2022",
"image": "family/ml-cpp-2-windows-2022",
},
"commands": [
Expand Down
6 changes: 3 additions & 3 deletions build-setup/windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ On the "Advanced Options" screen, check "Install for all users" and "Add Python

For the time being, do not take advantage of the option on the final installer screen to reconfigure the machine to allow paths longer than 260 characters. We still support Windows versions that do not have this option.

### PyTorch 2.3.1
### PyTorch 2.5.0

(This step requires a lot of memory. It failed on a machine with 12GB of RAM. It just about fitted on a 20GB machine. 32GB RAM is recommended.)

Expand All @@ -216,7 +216,7 @@ Next, in a Git bash shell run:

```
cd /c/tools
git clone --depth=1 --branch=v2.3.1 https://github.com/pytorch/pytorch.git
git clone --depth=1 --branch=v2.5.0 https://github.com/pytorch/pytorch.git
cd pytorch
git submodule sync
git submodule update --init --recursive
Expand Down Expand Up @@ -272,7 +272,7 @@ set USE_QNNPACK=OFF
set USE_PYTORCH_QNNPACK=OFF
set USE_XNNPACK=OFF
set MSVC_Z7_OVERRIDE=OFF
set PYTORCH_BUILD_VERSION=2.3.1
set PYTORCH_BUILD_VERSION=2.5.0
set PYTORCH_BUILD_NUMBER=1
python setup.py install
```
Expand Down
4 changes: 2 additions & 2 deletions dev-tools/build_windows_third_party_deps.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ mv "C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Tools\MSVC\$f\
# Build and install PyTorch (this may take a while)
Write-Host "--- Installing PyTorch locally"
cd c:\tools
git clone --depth=1 --branch=v2.3.1 https://github.com/pytorch/pytorch.git
git clone --depth=1 --branch=v2.5.0 https://github.com/pytorch/pytorch.git
cd pytorch
git submodule sync
git submodule update --init --recursive
Expand All @@ -131,7 +131,7 @@ set USE_QNNPACK=OFF
set USE_PYTORCH_QNNPACK=OFF
set USE_XNNPACK=OFF
set MSVC_Z7_OVERRIDE=OFF
set PYTORCH_BUILD_VERSION=2.3.1
set PYTORCH_BUILD_VERSION=2.5.0
set PYTORCH_BUILD_NUMBER=1
python setup.py install
Write-Host "--- Done Installing PyTorch locally"
Expand Down
1 change: 1 addition & 0 deletions docs/CHANGELOG.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

=== Enhancements

* Update the PyTorch library to version 2.5.0. (See {ml-pull}2783[#2783].)
* Upgrade Boost libraries to version 1.86. (See {ml-pull}2780[#2780].)

== {es} version 8.16.0
Expand Down